Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] v-dialog does not render when the v-model's value starts at a true value #9175

Closed
nmummau opened this issue Oct 2, 2019 · 3 comments · May be fixed by ajesse11x/ethereumbook#1 or ajesse11x/vuetify#2
Assignees
Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected
Milestone

Comments

@nmummau
Copy link

nmummau commented Oct 2, 2019

Environment

Vuetify Version: 2.1.0
Last working version: 2.0.19
Vue Version: 2.6.10
Browsers: Chrome 77.0.3865.90
OS: Linux x86_64

Steps to reproduce

  1. Edit the codepen of the first v-dialog example on the docs and make it so the the v-model's bound value is "true" by default.
  2. Save and reload the codepen with your change
    BUG: for some reason when the v-model's value is set to true from the start, the dialog does not render...

Expected Behavior

v-model's value can be set to true from the start. This is helpful when globally registering components in Vue that are strictly for Dialog purposes. When a calling component activates the registered dialog component, I expect the dialog's v-model to be true from the start.

Actual Behavior

Dialog never appears.

Reproduction Link

https://codepen.io/nmummau/pen/oNvKYOB?editors=1010

Other comments

As a work around, if set the dialog's v-model value to false to begin with... Then create a sleep() on the created() hook of the dialog component, and once that resolves set the v-model's value to true. Then the component appears!

I rolled back my project to use vuetify@2.0.19 and everything is back to a functional state. I'll wait to upgrade until this bug is fixed.

@ghost ghost added the S: triage label Oct 2, 2019
@KaelWD KaelWD added C: VDialog VDialog T: bug Functionality that does not work as intended/expected and removed S: triage labels Oct 2, 2019
@KaelWD KaelWD self-assigned this Oct 2, 2019
@KaelWD KaelWD closed this as completed in 19bf5d3 Oct 2, 2019
@KaelWD KaelWD added this to the v2.1.x milestone Oct 2, 2019
@yooneskh
Copy link

yooneskh commented Oct 2, 2019

Temporary fix for this

.v-dialog__container {
    display: unset; 
}

@shivamrr9
Copy link

shivamrr9 commented Dec 26, 2019

Temporary fix for this

.v-dialog__container {
    display: unset; 
}

This didn't worked for me
is there any way which does not sets v-dialog on close to 'display:none" in v1.5
rather re-renders it so that vue life cycle methods can be used

@yooneskh
Copy link

Temporary fix for this

.v-dialog__container {
    display: unset; 
}

This didn't worked for me
is there any way which does not sets v-dialog on close to 'display:none" in v1.5
rather re-renders it so that vue life cycle methods can be used

This bug is fixed and you do not need my workaround anymore. If you want life cycle events to fire, you must put a v-if on parent element and toggle it accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDialog VDialog T: bug Functionality that does not work as intended/expected
Projects
None yet
4 participants