fix(detachable): detach when lazy and inititally open

fixes #9175
vuetifyjs · Oct 2, 2019 · 19bf5d3 · 19bf5d3 · KaelWD · Oct 2, 2019
1 parent 9890255
commit 19bf5d3
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 15 deletions.
diff --git a/packages/vuetify/src/components/VMenu/__tests__/VMenu.spec.ts b/packages/vuetify/src/components/VMenu/__tests__/VMenu.spec.ts
@@ -122,6 +122,7 @@ describe('VMenu.ts', () => {
       methods: { activate },
     })
     expect(activate).toHaveBeenCalled()
+    expect('Unable to locate target [data-app]').toHaveBeenTipped()
   })
 
   it('should update position dynamically', async () => {
@@ -145,6 +146,7 @@ describe('VMenu.ts', () => {
       positionY: 220,
     })
     expect(content.attributes('style')).toMatchSnapshot()
+    expect('Unable to locate target [data-app]').toHaveBeenTipped()
   })
 
   it('should select next and previous tiles and skip non links/disabled', () => {

diff --git a/packages/vuetify/src/components/VTooltip/__tests__/__snapshots__/VTooltip.spec.ts.snap b/packages/vuetify/src/components/VTooltip/__tests__/__snapshots__/VTooltip.spec.ts.snap
@@ -30,13 +30,6 @@ exports[`VTooltip should render component with custom eager and match snapshot 1
 
 exports[`VTooltip should render component with min/max width and match snapshot 1`] = `
 <span class="v-tooltip">
-  <div class="v-tooltip__content menuable__content__active"
-       style="left: 0px; max-width: 200px; min-width: 100px; opacity: 0.9; top: 12px; z-index: 8; display: none;"
-  >
-    <span>
-      content
-    </span>
-  </div>
   <span>
     activator
   </span>
@@ -45,13 +38,6 @@ exports[`VTooltip should render component with min/max width and match snapshot
 
 exports[`VTooltip should render component with value=true and match snapshot 1`] = `
 <span class="v-tooltip">
-  <div class="v-tooltip__content menuable__content__active"
-       style="left: 0px; max-width: auto; opacity: 0.9; top: 12px; z-index: 8; display: none;"
-  >
-    <span>
-      content
-    </span>
-  </div>
   <span>
     activator
   </span>

diff --git a/packages/vuetify/src/mixins/detachable/index.ts b/packages/vuetify/src/mixins/detachable/index.ts
@@ -77,7 +77,7 @@ export default mixins<options &
   },
 
   mounted () {
-    this.eager && this.initDetach()
+    this.hasContent && this.initDetach()
   },
 
   deactivated () {