Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel improvements #946

Closed
sredbull opened this issue Jul 10, 2017 · 3 comments
Closed

Carousel improvements #946

sredbull opened this issue Jul 10, 2017 · 3 comments
Assignees
Labels
T: enhancement Functionality that enhances existing features

Comments

@sredbull
Copy link

sredbull commented Jul 10, 2017

Look at this codepen:

The following features will be a great addition to the carousel component:

  • Have an option to have a transparent background (the codepen's background is 1x1 transparent pixel).
  • Have an option to hide the next / previous buttons.
  • The next / previous buttons should follow the dark / light theme (not tested myself).
  • Slide on mouse event. (Maybe with custom effects). Already available.
  • The slot is currently center aligned that is ok-ish, but with the codepen I provided, I would have thought the card was top left aligned.
  • The slot content disappears after a while.
  • Should have an option to disable the touch event on mobile browsers (currently there is by default a slide right / left binding that switches pages but this is also triggered when the slot has scrollable content, tested on vertical scroll only).
@johnleider johnleider self-assigned this Jul 10, 2017
@johnleider johnleider added the T: enhancement Functionality that enhances existing features label Jul 10, 2017
@guykatz
Copy link

guykatz commented Jul 18, 2017

also please remove the requirement for the src property of the carousel item component (could be optional I guess but not required)

johnleider added a commit that referenced this issue Jul 23, 2017
@johnleider
Copy link
Member

  • You can now omit the src entirely.
  • You can now set left-control-icon or right-control-icon
  • Theme options added to carousel, can be set with dark or light
  • Already available
  • I'm not sure what you mean
  • Again, don't know what you mean, submit a bug issue
  • Something we can maybe add in the future, but for now, I don't think scroll behavior is expected with a carousel

@lock
Copy link

lock bot commented Apr 16, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: enhancement Functionality that enhances existing features
Projects
None yet
Development

No branches or pull requests

3 participants