Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Setting VCard loading prop should not disable the component content #9889

Closed
wkramer opened this issue Dec 5, 2019 · 0 comments · Fixed by #9892 or drakeg/vue_learn#18
Closed

[Feature Request] Setting VCard loading prop should not disable the component content #9889

wkramer opened this issue Dec 5, 2019 · 0 comments · Fixed by #9892 or drakeg/vue_learn#18
Labels
C: VCard VCard S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected

Comments

@wkramer
Copy link

wkramer commented Dec 5, 2019

Problem to solve

I want to use the loading indicator of the VCard component to indicate that data is being refreshed in the background, but the component itself should remain active.

In the current release, setting the loading prop disables the content of the VCard component. The user can no longer interact with it.

Proposed solution

Setting the loading prop on VCard should only display the visual loading indicator.
This is in agreement with the behavior of the loading prop on VSelect.

The developer can use the disabled prop to disable the component when required.
@ghost ghost added the S: triage label Dec 5, 2019
@johnleider johnleider added T: feature A new feature and removed S: triage labels Dec 5, 2019
@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected and removed T: feature A new feature labels Dec 5, 2019
jacekkarczmarczyk added a commit that referenced this issue Dec 5, 2019
@jacekkarczmarczyk
fix(VCard): loading shouldn't disable the card
1586446 
fixes #9889
@jacekkarczmarczyk jacekkarczmarczyk mentioned this issue Dec 5, 2019
Merged
9 tasks
@jacekkarczmarczyk jacekkarczmarczyk added the S: has PR The issue has a pending Pull Request label Dec 5, 2019
johnleider pushed a commit that referenced this issue Dec 5, 2019
@jacekkarczmarczyk @johnleider
fix(VCard): loading shouldn't disable the card (#9892)
bb12b96 
fixes #9889
@snyk-bot snyk-bot mentioned this issue Dec 19, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Jan 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: VCard VCard S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
3 participants
@wkramer @johnleider @jacekkarczmarczyk