Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCard): loading shouldn't disable the card #9892

Merged
merged 1 commit into from Dec 5, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #9889

How Has This Been Tested?

playground, unit

Markup:

<template>
  <v-container>
    <v-card loading>
      <v-card-text>
        <v-btn>Foo</v-btn>
      </v-card-text>
    </v-card>
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected C: VCard VCard labels Dec 5, 2019
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Dec 5, 2019
@johnleider johnleider added this to the v2.1.x milestone Dec 5, 2019
@johnleider johnleider merged commit bb12b96 into master Dec 5, 2019
@johnleider johnleider deleted the fix/#9889-card-loading branch December 5, 2019 16:39
@lock lock bot locked as resolved and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VCard VCard T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Setting VCard loading prop should not disable the component content
2 participants