Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBanner): remove bottom-border on outlined banner #12548

Conversation

daikiojm
Copy link
Contributor

@daikiojm daikiojm commented Nov 3, 2020

Description

fixes #12172

Motivation and Context

fixes #12172

How Has This Been Tested?

visually


before behavior
スクリーンショット_2020-11-03_17_05_25

after behavior
スクリーンショット 2020-11-03 16 59 08

Markup:

<template>
  <v-container>
    <v-row class="ma-4">
      <div
        d-flex
        flex-row
        class="ma-4"
      >
        <p class="teal">normal</p>
        <v-banner
          width="400px"
          class="ma-4"
        > {{ message }}
        </v-banner>
      </div>
    </v-row>
    <v-row class="ma-4">
      <div
        d-flex
        flex-row
        class="ma-4"
      >
        <p class="teal">outlined</p>
        <v-banner
          outlined
          width="400px"
          class="ma-4"
        > {{ message }}
        </v-banner>
      </div>
    </v-row>
    <v-row class="ma-4">
      <div
        d-flex
        flex-row
        class="ma-4"
      >
        <p class="teal">elevation</p>
        <v-banner
          width="400px"
          class="ma-4"
          elevation="4"
        > {{ message }}
        </v-banner>
      </div>
    </v-row>
    <v-row class="ma-4">
      <div
        d-flex
        flex-row
        class="ma-4"
      >
        <p class="teal">shaped and outlined</p>
        <v-banner
          shaped
          outlined
          width="400px"
          class="ma-4"
        > {{ message }}
        </v-banner>
      </div>
    </v-row>
    <v-row class="ma-4">
      <div
        d-flex
        flex-row
        class="ma-4"
      >
        <p class="teal">shaped and elevation</p>
        <v-banner
          shaped
          width="400px"
          class="ma-4"
          elevation="4"
        > {{ message }}
        </v-banner>
      </div>
    </v-row>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      message: 'Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent cursus nec sem id malesuada. Curabitur lacinia sem et turpis euismod, eget elementum ex pretium.',
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@daikiojm daikiojm changed the title fix(VBanner): remove bottom-border on shaped outlined banner fix(VBanner): remove bottom-border on outlined banner Nov 3, 2020
@KaelWD KaelWD merged commit 49e25bb into vuetifyjs:master Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Second bottom-border on shaped outlined banner
3 participants