Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VFileInput): update to v3 #14029

Merged
merged 17 commits into from
Aug 17, 2021
Merged

feat(VFileInput): update to v3 #14029

merged 17 commits into from
Aug 17, 2021

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Aug 4, 2021

Fixes #9349

Description

Motivation and Context

v3

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <div class="pa-10">
      <h3>Variants</h3>
      <template v-for="variant in ['underlined', 'outlined', 'filled', 'contained', 'plain']" :key="variant">
        <v-file-input :label="variant" :variant="variant" class="ma-5" />
      </template>

      <h3>Multiple</h3>
      <v-file-input label="bar" multiple class="ma-5" />

      <h3>Multiple Counter</h3>
      <v-file-input label="bar" multiple counter class="ma-5" />

      <h3>Multiple Counter ShowSize</h3>
      <v-file-input label="bar" multiple counter show-size class="ma-5" />

      <h3>Not Clearable</h3>
      <v-file-input label="bar" :clearable="false" class="ma-5" />

      <h3>No prepend icon</h3>
      <v-file-input label="bar" :prepend-outer-icon="null" class="ma-5" />

      <h3>Programmatic</h3>
      <v-file-input label="bar" v-model="file" class="ma-5" />
      {{ file }}
      <v-btn @click="set">set</v-btn>
      <v-btn @click="clear">clear</v-btn>
    </div>
  </v-app>
</template>

<script>
  export default {
    name: 'Playground',
    data: () => ({
      model: 1,
      disabled: false,
      file: null,
      toSet: null,
    }),
    watch: {
      file (value) {
        value && value.length && (this.toSet = value)
      },
    },
    methods: {
      set () {
        this.file = this.toSet
      },
      clear () {
        this.file = []
      },
    },
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@nekosaur nekosaur added this to the v3.0.0 milestone Aug 4, 2021
@nekosaur nekosaur added this to In progress in Vuetify 3 - Titan via automation Aug 4, 2021
@nekosaur nekosaur self-assigned this Aug 4, 2021
@nekosaur nekosaur changed the title wip feat(VFileInput): update to v3 Aug 6, 2021
@johnleider johnleider added the T: feature A new feature label Aug 12, 2021
@johnleider johnleider marked this pull request as ready for review August 12, 2021 20:33
host: process.env.HOST || 'localhost',
port: process.env.PORT || '8080',
firewall: false,
// firewall: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to the new webpack-dev-server schema

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to find any information regarding this in webpack-dev-server@3.x, only 4.0-rc. Could you clarify this?

@KaelWD KaelWD merged commit d73e7c4 into next Aug 17, 2021
Vuetify 3 - Titan automation moved this from In progress to Done Aug 17, 2021
@KaelWD KaelWD deleted the feat/v3-file-input branch August 17, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants