Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VNoSsr): create new component #14076

Merged
merged 5 commits into from
Aug 27, 2021
Merged

feat(VNoSsr): create new component #14076

merged 5 commits into from
Aug 27, 2021

Conversation

blalan05
Copy link
Member

Description

This creates a new component that wraps content that doesn't get rendered by Server-side generation.

How Has This Been Tested?

Markup:

<template>
  <div>Server-side; This should display</div>
  <v-no-ssr> This is only supposed to be on the client</v-no-ssr>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@blalan05 blalan05 added C: New Component This issue would need a new component to be developed. Vuetify 3 - Phase 3 labels Aug 23, 2021
@blalan05 blalan05 self-assigned this Aug 23, 2021
@johnleider johnleider added this to the v3.0.0 milestone Aug 24, 2021
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to populate it, but can you put in a placeholder page to the docs? Thank you.

packages/vuetify/src/components/VNoSsr/VNoSsr.tsx Outdated Show resolved Hide resolved
@johnleider johnleider merged commit 5dcc4bf into next Aug 27, 2021
@johnleider johnleider deleted the feat/v3-no-ssr branch August 27, 2021 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: New Component This issue would need a new component to be developed. Vuetify 3 - Phase 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants