feat(styles): use the sass module system instead of @import #14094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaelWD
force-pushed
the
feat/sass-modules
branch
2 times, most recently
from
ae8ed79
to
b7eae4c
Compare
KaelWD
force-pushed
the
feat/sass-modules
branch
from
b7eae4c
to
0185476
Compare
johnleider
requested changes
Aug 28, 2021
There was a problem hiding this comment.
Looks good. Would it have been possible to keep the index sass files or was there a specific reason not to? Reference: https://sass-lang.com/documentation/at-rules/use#index-files
|
Could but it would be pretty pointless because all it would be is |
KaelWD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sass-lang.com/documentation/at-rules/use
https://sass-lang.com/documentation/at-rules/forward
Fixes #13694
Also adds a
$resetvariable and allows$utilitiesto be set to false.