-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VDataTable): forward arbitrary row events #15617
Merged
Merged
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0e85a93
feat(VDataTable): emit mouseover:row and mouseleave:row
FBuervenich 39220b1
Revert "feat(VDataTable): emit mouseover:row and mouseleave:row"
FBuervenich c32dd34
Forward events for table rows to internal element
FBuervenich 60d7231
Merge branch 'v2-dev' into FBuervenich-dev
KaelWD 5760376
emit native event as the first argument
KaelWD a02657d
remove newline
KaelWD 0fc5264
simplify docs
KaelWD File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,6 +31,7 @@ import MobileRow from './MobileRow' | |
|
||
// Mixins | ||
import Loadable from '../../mixins/loadable' | ||
import Mouse from '../../mixins/mouse' | ||
|
||
// Directives | ||
import ripple from '../../directives/ripple' | ||
|
@@ -74,6 +75,7 @@ function searchTableItems ( | |
export default mixins( | ||
VDataIterator, | ||
Loadable, | ||
Mouse, | ||
).extend({ | ||
name: 'v-data-table', | ||
|
||
|
@@ -241,7 +243,9 @@ export default mixins( | |
}, | ||
}, | ||
on: { | ||
// TODO: for click, the first argument should be the event, and the second argument should be data, | ||
...this.getDefaultMouseEventHandlers(':row', () => data), | ||
// TODO: for click, contextmenu and dblclick, the first argument should be data, | ||
// and the second argument should be the event, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I didn't realise calendar was like this too. This is actually backwards, the first argument has to be the event so modifiers like |
||
// but this is a breaking change so it's for v3 | ||
click: (event: MouseEvent) => this.$emit('click:row', item, data, event), | ||
contextmenu: (event: MouseEvent) => this.$emit('contextmenu:row', event, data), | ||
|
4 changes: 2 additions & 2 deletions
4
.../VCalendar/mixins/__tests__/mouse.spec.ts → .../src/mixins/mouse/__tests__/mouse.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
.../src/components/VCalendar/mixins/mouse.ts → packages/vuetify/src/mixins/mouse/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
|
||
import Vue from 'vue' | ||
|
||
export type MouseHandler = (e: MouseEvent | TouchEvent) => any | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is really necessary considering it takes any dom event now.