Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTabs): rtl buttons and scroll behaviour #15701

Merged
merged 2 commits into from Aug 30, 2022
Merged

fix(VTabs): rtl buttons and scroll behaviour #15701

merged 2 commits into from Aug 30, 2022

Conversation

nekosaur
Copy link
Member

closes #15400

Description

fixes reported bug, and cleans up additional issues surrounding rtl + direction variants

Motivation and Context

How Has This Been Tested?

Markup:

<template>
  <v-locale-provider :rtl="rtl">
    <v-card>
      <v-tabs
        background-color="deep-purple-darken-4"
        centerActive
      >
        <v-tab>One</v-tab>
        <v-tab>Two</v-tab>
        <v-tab>Three</v-tab>
        <v-tab>Four</v-tab>
        <v-tab>Five</v-tab>
        <v-tab>Six</v-tab>
        <v-tab>Seven</v-tab>
        <v-tab>Eight</v-tab>
        <v-tab>Nine</v-tab>
        <v-tab>Ten</v-tab>
        <v-tab>Eleven</v-tab>
        <v-tab>Twelve</v-tab>
        <v-tab>Thirteen</v-tab>
        <v-tab>Fourteen</v-tab>
        <v-tab>Fifteen</v-tab>
        <v-tab>Sixteen</v-tab>
        <v-tab>Seventeen</v-tab>
        <v-tab>Eighteen</v-tab>
        <v-tab>Nineteen</v-tab>
        <v-tab>Twenty</v-tab>
      </v-tabs>
    </v-card>
    <v-btn @click="rtl = !rtl">rtl</v-btn>
  </v-locale-provider>
</template>

<script>

  export default {
    data: () => ({
      tabs: null,
      slider1: 0,
      slider2: 0,
      rtl: true,
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@nekosaur nekosaur added this to the v3.0.0-beta milestone Aug 27, 2022
@nekosaur nekosaur self-assigned this Aug 27, 2022
@KaelWD KaelWD merged commit b3eae14 into next Aug 30, 2022
@KaelWD KaelWD deleted the fix/tabs-rtl-15400 branch August 30, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants