fix(vfield): standardize descendants to fix spacing #16132

kelliedlynch · 2022-11-19T23:45:15Z

Description

Standardized the sizing and spacing of VInput-VField descendants to fix multiple bugs relating to
field resizing and text alignment. All field variants now have identical sizing whether they contain input or not.
This required changing the size of VChip elements inside a VField. Fixes #15980, #16048, and #15948

Motivation and Context

Fixes #15980, #16048, and #15948, as well as several other unreported spacing and resizing issues. Fields should no longer resize on input, and cursors and text will stay in one position regardless of field state.

How Has This Been Tested?

Comprehensive visual testing (see markup below).
Duplicated in Codepen link to compare with current version: https://codepen.io/kelliedlynch/pen/qBKXBPN

Markup:

<template>
  <v-app>
    <v-container fluid>
      <v-row class="justify-start" style="background-color:azure">
        <v-col cols="2">
          <v-checkbox
            label="Prepend Icon"
            v-model="prependIcon"
            density="none"
          />
          <v-checkbox
            label="Prepend Inner Icon"
            v-model="prependInnerIcon"
            density="none"
          />
        </v-col>
        <v-col cols="2">
          <v-checkbox
            label="Append Icon"
            v-model="appendIcon"
            density="none"
          />
          <v-checkbox
            label="Append Inner Icon"
            v-model="appendInnerIcon"
            density="none"
          />
        </v-col>
        <v-col cols="2">
          <v-select 
            label="Variant"
            :items="variants"
            v-model="variant"
            density="compact"
          />
        </v-col>
        <v-col cols="2">
          <v-select
            label="Category of Field"
            :items="pages"
            v-model="page"
            density="compact"
          />
        </v-col>
      </v-row>
      <v-row class="flex-wrap" style="margin-top:12px">
        <!-- TEXT FIELDS -->
        <v-col cols="2" class="pa-1" >
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-text-field
                :label="showLabel ? 'Text Field Labeled ' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :model-value="showLabel ? 'Text Labeled ' + density + ' Dirty' : 'Text No-label ' + density + ' Dirty'"
                :placeholder="!showLabel ? 'Text No-Label ' + density + ' Dirty' : ''"
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
              ></v-text-field>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-text-field
                :label="showLabel ? 'Text Field Labeled' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :placeholder="!showLabel ? 'Text No-Label ' + density + ' Clean' : ''"
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
              ></v-text-field>
            </v-container>
          </v-container>
        </v-col>

        <!-- SINGLE-LINE TEXT FIELDS -->
        <v-col cols="2" class="pa-1" v-if="page == 'Text Fields'">
            <v-container v-for="density in densities" class="pa-0">
              <v-text-field
                :label="'Text Field Single Line ' + ' ' + density + ' Dirty'"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :model-value="'Text Single Line ' + density + ' Dirty'"
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
                single-line
              ></v-text-field>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-text-field
                :label="'Text Field Single Line ' + ' ' + density + ' Clean'"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
                single-line
              ></v-text-field>
            </v-container>
        </v-col>

        <!-- TEXTAREAS -->
        <v-col cols="2" class="pa-1" v-if="page == 'Textareas'" v-for="showLabel in showLabels">
            <v-container v-for="density in densities" class="pa-0">
              <VTextarea
                :label="showLabel ? 'Textarea Labeled ' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :model-value="showLabel ? 'Text Labeled ' + density + ' Dirty' : 'Text No-label ' + density + ' Dirty'"
                :placeholder="!showLabel ? 'Text No-Label ' + density + ' Dirty' : ''"
                clearable
                auto-grow
                rows="1"
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
              ></VTextarea>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-textarea
                :label="showLabel ? 'Textarea Labeled' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :placeholder="!showLabel ? 'Text No-Label ' + density + ' Clean' : ''"
                clearable
                auto-grow
                rows="1"
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
              ></v-textarea>
            </v-container>
        </v-col>

        <!-- SELECT WITH CHIPS -->
        <v-col cols="2" class="pa-1"  v-if="page == 'Selects'">
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-select
                :label="showLabel ? 'Select Chips' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="selected"
                chips
                closable-chips
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-select>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-select
                :label="showLabel ? 'Select Chips' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="unselected"
                chips
                closable-chips
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-select>
            </v-container>
          </v-container>
        </v-col>

        <!-- SELECT WITHOUT CHIPS -->
        <v-col cols="2" class="pa-1"  v-if="page == 'Selects'">
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-select
                :label="showLabel ? 'Select No-chips' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="selected"
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-select>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-select
                :label="showLabel ? 'Select No-chips' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="unselected"
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-select>
            </v-container>
          </v-container>
        </v-col>

        <!-- COMBOBOX WITH CHIPS -->
        <v-col cols="2" class="pa-1"  v-if="page == 'Combos'">
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-combobox
                :label="showLabel ? 'Combobox Chips' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="selected"
                chips
                closable-chips
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-combobox>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-combobox
                :label="showLabel ? 'Combobox Chips' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="unselected"
                chips
                closable-chips
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-combobox>
            </v-container>
          </v-container>
        </v-col>

        <!-- COMBOBOX WITHOUT CHIPS -->
        <v-col cols="2" class="pa-1"  v-if="page == 'Combos'">
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-combobox
                :label="showLabel ? 'Combobox No-chips' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="selected"
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-combobox>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-combobox
                :label="showLabel ? 'Combobox No-chips' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="unselected"
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-combobox>
            </v-container>
          </v-container>
        </v-col>

        <!-- AUTOCOMPLETE WITH CHIPS -->
        <v-col cols="2" class="pa-1"  v-if="page == 'Combos'">
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-autocomplete
                :label="showLabel ? 'Autocomplete Chips' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="selected"
                chips
                closable-chips
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-autocomplete>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-autocomplete
                :label="showLabel ? 'Autocomplete Chips' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="unselected"
                chips
                closable-chips
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-autocomplete>
            </v-container>
          </v-container>
        </v-col>

        <!-- AUTOCOMPLETE WITHOUT CHIPS -->
        <v-col cols="2" class="pa-1"  v-if="page == 'Combos'">
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-autocomplete
                :label="showLabel ? 'Autocomplete No-chips' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="selected"
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-autocomplete>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-autocomplete
                :label="showLabel ? 'Autocomplete No-chips' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                :items="items"
                v-model="unselected"
                multiple
                clearable
                :prepend-icon="prependIcon ? 'mdi-map-marker' : ''"
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
              ></v-autocomplete>
            </v-container>
          </v-container>
        </v-col>

        <!-- FILE INPUT WITH CHIPS -->
        <v-col cols="2" class="pa-1" v-if="page == 'Text Fields'">
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-file-input
                :label="showLabel ? 'File Input Chips' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()"
                chips
                closable-chips
                multiple
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
              ></v-file-input>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-file-input
                :label="showLabel ? 'File Input Chips' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                chips
                closable-chips
                multiple
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
              ></v-file-input>
            </v-container>
          </v-container>
        </v-col>

        <!-- FILE INPUT WITHOUT CHIPS -->
        <v-col cols="2" class="pa-1" v-if="page == 'Text Fields'" >
          <v-container v-for="showLabel in showLabels" class="pa-0" >
            <v-container v-for="density in densities" class="pa-0">
              <v-file-input
                :label="showLabel ? 'File Input No-chips' + ' ' + density + ' Dirty' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                multiple
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
              ></v-file-input>
            </v-container>
            <v-container v-for="density in densities" class="pa-0">
              <v-file-input
                :label="showLabel ? 'File Input No-chips' + ' ' + density + ' Clean' : ''"
                :variant="variant.toLowerCase()"
                :density="density.toLowerCase()" 
                multiple
                :prepend-inner-icon="prependInnerIcon ? 'mdi-map-marker' : ''"
                :append-icon="appendIcon ? 'mdi-map-marker' : ''"
                :append-inner-icon="appendInnerIcon ? 'mdi-map-marker' : ''"
              ></v-file-input>
            </v-container>
          </v-container>
        </v-col>
      </v-row>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    name: 'Playground',
    setup () {

    },
    data: () => {
      return {
        showLabels: [
          true, false
        ],
        prependIcon: false,
        prependInnerIcon: false,
        appendIcon: false,
        appendInnerIcon: false,
        pages: [
          "Text Fields",
          "Selects",
          "Combos",
          "Textareas"
        ],
        page: "Text Fields",
        variants: [
          "Filled",
          "Outlined",
          "Solo",
          "Plain",
          "Underlined",
        ],
        variant: "Filled",
        usesChips: [
          true, false
        ],
        items: [
          "lorem",
          "ipsum dolor sit amet", 
          "consectetur",
          "adipiscing elit", 
          "ut enim ad minim veniam", 
          "quis nostrud",
          "exercitation ullamco laboris"],
        selected: [
          "lorem",
        ],
        unselected: [],
        densities: [
          "Compact",
          "Comfortable",
          "Default",
        ],
        labeled: [
          "Labeled",
          "Unlabeled",
        ],
        isFieldClean: [
          true, false
        ]
      }
    }
  }
</script>

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

The PR title is no longer than 64 characters.
The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
My code follows the code style of this project.
I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

Standardized the sizing and spacing of VInput-VField descendants to fix multiple bugs relating to field resizing and text alignment. All field densities are now identical sizes across all variants. This required changing the size of VChip elements inside a VField. fix vuetifyjs#15980, fix vuetifyjs#16048, fix vuetifyjs#15948

johnleider · 2022-11-22T16:59:03Z

Looking good but there are some alignment issues for filled inputs:

Easiest way to see this is by building Vuetify and running the docs locally and check out the Form & input controls

kelliedlynch · 2022-11-22T18:08:18Z

Whoops--accidentally deleted something I shouldn't in my final cleanup. I'll have the fix up shortly.

johnleider · 2022-11-29T19:52:18Z

This is what I see when I compare your branch to next:

kelliedlynch · 2022-11-29T21:02:19Z

Can you clarify the issue? The only difference I see is that next has inconsistent sizing, and mine doesn't. From looking at constants and defaults in next, it looks like the larger size (42/48/56px) should be the correct one, and that's the size that allows enough room for field elements.

johnleider · 2022-11-30T18:24:59Z

Can you clarify the issue? The only difference I see is that next has inconsistent sizing, and mine doesn't. From looking at constants and defaults in next, it looks like the larger size (42/48/56px) should be the correct one, and that's the size that allows enough room for field elements.

The label is too close to the top of the input and looks offset improperly. The label should be closer to the input text:

Lowered floating labels slightly to match original spacing

kelliedlynch · 2022-12-02T20:53:37Z

Got it, thanks for the clarification. Should be fixed now.

johnleider · 2022-11-22T16:41:42Z

packages/vuetify/src/components/VField/_variables.scss

+$field-control-density: ('default': 0, 'comfortable': -1, 'compact': -2) !default;
+$field-chips-margin-top: ('default': 1, 'comfortable': 0, 'compact': 0) !default;
+$field-chips-margin-bottom: ('default': 3, 'comfortable': 3, 'compact': 2) !default;
+$field-chip-height: 20px;


Suggested change

$field-chip-height: 20px;

$field-chip-height: 20px !default;

johnleider · 2022-11-22T16:43:15Z

packages/vuetify/src/components/VSelect/VSelect.tsx

@@ -209,7 +209,7 @@ export const VSelect = genericComponent<new <
            'v-select',
            {
              'v-select--active-menu': menu.value,
-              'v-select--chips': !!props.chips,
+              // 'v-select--chips': !!props.chips,


Suggested change

// 'v-select--chips': !!props.chips,

johnleider · 2022-12-05T16:59:31Z

packages/vuetify/src/components/VField/VField.sass

+  @at-root
+    @include tools.density('v-input', $field-control-density) using ($modifier)
+      --v-field-prepend-append-padding-top: #{$field-control-padding-top + $modifier}
+      // --v-field-padding-bottom: #{$field-control-padding-bottom + $modifier}


Suggested change

// --v-field-padding-bottom: #{$field-control-padding-bottom + $modifier}

johnleider · 2022-12-05T17:00:02Z

packages/vuetify/src/components/VField/VField.sass

@@ -213,8 +250,14 @@

  .v-field--error:not(.v-field--disabled) &
    color: rgb(var(--v-theme-error))
-
+  


Suggested change

KaelWD · 2022-12-06T16:12:31Z

Prefix and suffix are broken:

Underlined has too much space below the label and value:

KaelWD · 2022-12-06T16:14:43Z

packages/vuetify/src/components/VField/VField.sass

+      // --v-field-padding-bottom: #{$field-control-padding-bottom + $modifier}
+      --v-field-padding-top: #{$field-control-padding-top + $modifier}
+      --v-field-padding-bottom: #{$field-control-padding-bottom + $modifier}
+      &.v-textarea .v-field:not(.v-field--no-label)


I was trying to avoid using :not() where possible because it can increase specificity a lot and make it hard to follow what rules are being applied

kelliedlynch changed the title ~~Standardize VField descendants to fix spacing~~ fix(vfield): standardize descendants to fix spacing Nov 20, 2022

kelliedlynch force-pushed the fix/v-input-v-field-15980 branch from b75c264 to e99b484 Compare November 20, 2022 18:33

johnleider self-requested a review November 22, 2022 16:38

johnleider assigned kelliedlynch Nov 22, 2022

johnleider added C: VField T: bug Functionality that does not work as intended/expected labels Nov 22, 2022

fix(vfield): fix alignment on floating labels

9e68331

fix(vfield): fix spacing on floating labels

44dab12

johnleider force-pushed the next branch 2 times, most recently from e6199a3 to c4ab550 Compare November 29, 2022 02:50

johnleider added this to the v3.0.x milestone Nov 29, 2022

johnleider force-pushed the next branch from b6aed82 to ceaffe5 Compare November 29, 2022 23:53

fix(vfield): fix spacing on floating labels

3d76117

Lowered floating labels slightly to match original spacing

johnleider requested a review from KaelWD December 5, 2022 16:58

johnleider requested changes Dec 5, 2022

View reviewed changes

KaelWD reviewed Dec 6, 2022

View reviewed changes

KaelWD modified the milestones: v3.0.x, v3.1.x Jan 6, 2023

KaelWD added the S: has merge conflicts The pending Pull Request has merge conflicts label Jan 31, 2023

KaelWD marked this pull request as draft January 31, 2023 12:23

KaelWD changed the base branch from next to master February 5, 2023 14:26

johnleider force-pushed the master branch from afadc02 to 3f1b0f5 Compare March 23, 2023 18:52

KaelWD force-pushed the master branch 6 times, most recently from 7c417af to 070e2aa Compare May 24, 2023 13:23

johnleider force-pushed the master branch from 1e2d48a to 9437361 Compare June 1, 2023 17:13

KaelWD force-pushed the master branch from fb9a5de to 47fec87 Compare August 4, 2023 12:12

johnleider force-pushed the master branch from 36450de to 6fceb9c Compare August 28, 2023 19:30

MajesticPotatoe force-pushed the master branch 3 times, most recently from 7ce7b02 to 1adfeaa Compare October 12, 2023 13:13

MajesticPotatoe force-pushed the master branch 2 times, most recently from bb07313 to e5c1c07 Compare October 20, 2023 01:52

johnleider force-pushed the master branch 8 times, most recently from 7cd11a6 to d0765f1 Compare December 17, 2023 01:32

johnleider force-pushed the master branch 2 times, most recently from f931c2e to 748056c Compare December 28, 2023 22:41

KaelWD force-pushed the master branch 3 times, most recently from cd170f8 to 98e57dc Compare February 14, 2024 06:14

johnleider force-pushed the master branch from 0f61ac3 to 92c777b Compare April 11, 2024 20:15

johnleider force-pushed the master branch from 9d2ea6f to 43529fa Compare May 6, 2024 02:31

johnleider closed this May 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(vfield): standardize descendants to fix spacing #16132

fix(vfield): standardize descendants to fix spacing #16132

kelliedlynch commented Nov 19, 2022 •

edited

johnleider commented Nov 22, 2022

kelliedlynch commented Nov 22, 2022

johnleider commented Nov 29, 2022

kelliedlynch commented Nov 29, 2022

johnleider commented Nov 30, 2022

kelliedlynch commented Dec 2, 2022

johnleider Nov 22, 2022

johnleider Nov 22, 2022

johnleider Dec 5, 2022

johnleider Dec 5, 2022

KaelWD commented Dec 6, 2022

KaelWD Dec 6, 2022

		@@ -213,8 +250,14 @@

		.v-field--error:not(.v-field--disabled) &
		color: rgb(var(--v-theme-error))

fix(vfield): standardize descendants to fix spacing #16132

fix(vfield): standardize descendants to fix spacing #16132

Conversation

kelliedlynch commented Nov 19, 2022 • edited

Description

Motivation and Context

How Has This Been Tested?

Markup:

Types of changes

Checklist:

johnleider commented Nov 22, 2022

kelliedlynch commented Nov 22, 2022

johnleider commented Nov 29, 2022

kelliedlynch commented Nov 29, 2022

johnleider commented Nov 30, 2022

kelliedlynch commented Dec 2, 2022

johnleider Nov 22, 2022

Choose a reason for hiding this comment

johnleider Nov 22, 2022

Choose a reason for hiding this comment

johnleider Dec 5, 2022

Choose a reason for hiding this comment

johnleider Dec 5, 2022

Choose a reason for hiding this comment

KaelWD commented Dec 6, 2022

KaelWD Dec 6, 2022

Choose a reason for hiding this comment

kelliedlynch commented Nov 19, 2022 •

edited