Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(V-Menu): allow functions for closeOnClick in v-menu. #16278

Open
wants to merge 2 commits into
base: v2-stable
Choose a base branch
from

Conversation

jaydiazzz
Copy link

@jaydiazzz jaydiazzz commented Dec 14, 2022

Description

allow for closeOnClick property in the v-menu component to use a function provided by the developer, instead of the standard close procedure.

Motivation and Context

This is required for the case that you want to handle the value of v-menu manually while not having direct access. For example, if this is nested within v-select we need to be able to have access to the close event. This helps with customizability for the component and better control over it.

How Has This Been Tested?

By using this in my local instance and it having the intended affects while also allowing my other v-menu components to function normally.

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and backwards compatible changes and next for non-backwards compatible changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

…tion provided by the developer, instead of the standard close procedure.
@jaydiazzz jaydiazzz changed the title allow for closeOnClick property in the v-menu component to use a func… fix(V-Menu): allow functions for closeOnClick in v-menu. Dec 14, 2022
@johnleider johnleider requested a review from KaelWD January 3, 2023 22:21
@nekosaur nekosaur changed the title fix(V-Menu): allow functions for closeOnClick in v-menu. feat(V-Menu): allow functions for closeOnClick in v-menu. Jan 11, 2023
@nekosaur
Copy link
Member

This is a feature, not a fix

@jaydiazzz
Copy link
Author

This is a feature, not a fix

Will you be able to further explain what actions are necessary from this point?

@KaelWD
Copy link
Member

KaelWD commented Jan 12, 2023

It means rebase to v2-dev. How do you intend to use this anyway, you can already prevent menus from closing with :closeOnClick="false"

@KaelWD KaelWD changed the base branch from master to v2-stable February 5, 2023 09:25
@MajesticPotatoe MajesticPotatoe added T: feature A new feature C: VMenu VMenu labels Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants