New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VList): add lazy mode to VListGroup #16343
Open
tinou98
wants to merge
2
commits into
vuetifyjs:dev
Choose a base branch
from
tinou98:next
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a lazy composable that you might be able to use |
It does indeed simplify the code, but has the drawback of making lazy the default behaviour (might break/slow some application). |
KaelWD
force-pushed
the
master
branch
3 times, most recently
from
April 13, 2023 11:01
aa22a14
to
ca89962
Compare
KaelWD
force-pushed
the
master
branch
12 times, most recently
from
May 24, 2023 13:23
7c417af
to
070e2aa
Compare
Please update your fork and rebase this onto dev. |
johnleider
added
the
S: has merge conflicts
The pending Pull Request has merge conflicts
label
Jul 17, 2023
Add a `lazy` props to skip the rendering of children if the group has never been opened This allow to render instantly a list with ~1k elements (see example in docs)
Rebased |
johnleider
added
T: feature
A new feature
and removed
S: has merge conflicts
The pending Pull Request has merge conflicts
labels
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a
lazy
props to skip the rendering of children if the group has never been openedMotivation and Context
This allows to render instantly a list with ~1k elements (see example in docs)
How Has This Been Tested?
Manually (patched in my project, used to crash Chrome and Firefox, now work instantly).
Also added 2 Cypress test.
Markup:
Available in the documentation
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).