-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add VDataIterator to labs #16839
Conversation
48254ea
to
e073400
Compare
Made some effort to not reuse InternalItem since it's not applicable everywhere and we have a number of variants. InternalItem (now ListItem) has title, value, props, children We still use |
results.forEach(({ index, matches }) => { | ||
const item = transformedItems[index] | ||
const item = originalItems[index] | ||
filteredItems.value.push(item) | ||
filteredMatches.value.set(item.value, matches) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is expecting InternalItem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean
multiSort: Boolean, | ||
mustSort: Boolean, | ||
locale: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this take the global locale default value into account?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes. We should probably remove that prop and use locale composable instead. I don't think it's a good idea to have 3 different ways of setting the locale. Global + v-locale-provider using composable should be enough.
Description
adds data-iterator to labs
closes #13478
Markup: