Make sure the input exists #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some case, the input doesn't exist. For example, in http://owfhx5zzh.bkt.clouddn.com/#/, after logged in, the username is gone after the routing. http://owfhx5zzh.bkt.clouddn.com/#/ username: Mario, password: password
|
That site doesn't load at all for me, can you reproduce it in a codepen? |
KaelWD
added
the
S: needs reproduction
|
reproduction: https://codepen.io/KingMario/pen/MEorJL First, you'll be redirected to login route, hit Enter in the username field, then you'll get to the / route.
|
|
A screenshot: |
johnleider
requested changes
Sep 29, 2017
| @@ -158,6 +158,9 @@ export default { | |||
| this.$emit('blur', e) | |||
| }, | |||
| focus (e) { | |||
| if (!this.$refs.input) { | |||
KaelWD
added
pending review
johnleider
approved these changes
Oct 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some case, the input doesn't exist. For example, in http://owfhx5zzh.bkt.clouddn.com/#/, after logged in, if you refresh the page, the username with autofocus prop doesn't exisit.
Login info for http://owfhx5zzh.bkt.clouddn.com/#/
username: Mario, password: password
The error message got from console if you refresh the page: