Bugfix: Changing VDataTable mixin to reset expanded value to object instead o… #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f array Clicking a VDataTable header triggers a reset of the expanded property. The functionality requires an object, but this mixin sets it to an array. This causes VDataTable item-key values that are numbers to create an array the size of the item-key value. What we want is an object with an item-key to bool mapping.
Codecov Report
@@ Coverage Diff @@
## master #2666 +/- ##
=========================================
- Coverage 68.38% 68.28% -0.1%
=========================================
Files 118 118
Lines 3150 3150
Branches 998 998
=========================================
- Hits 2154 2151 -3
- Misses 711 714 +3
Partials 285 285
Continue to review full report at Codecov.
|
KaelWD
approved these changes
Nov 29, 2017
|
How do I make sure someone merges this in? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking a VDataTable header triggers a reset of the expanded property. The functionality requires an object, but this mixin sets it to an array. I believe this was missed in a previous bugfix.
The problematic code causes VDataTable numeric string item-key values to create an array the size of the item-key value. What we want is an object with an item-key to bool mapping. This change is tested and working.