fix(menuable): Enforce the check that $refs.content exist in sneakPeek #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If $refs.content is removed between sneakPeek being called and the animation frame fires, it becomes undefined in the callback. Then it results with a `Uncaught TypeError: Cannot read property 'style' of undefined` This fix ensure that $refs.content exists.
Codecov Report
@@ Coverage Diff @@
## master #2721 +/- ##
==========================================
+ Coverage 68.04% 68.13% +0.09%
==========================================
Files 116 116
Lines 3079 3079
Branches 987 986 -1
==========================================
+ Hits 2095 2098 +3
+ Misses 699 696 -3
Partials 285 285
Continue to review full report at Codecov.
|
|
For future reference: 8792777 |
KaelWD
approved these changes
Dec 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
$refs.contentis removed betweensneakPeekbeing called and the animation frame fires, it becomes undefined in the callback.Then it results with a
Uncaught TypeError: Cannot read property 'style' of undefinedThis fix ensure that $refs.content exists.
===
Thanks Kael for the help to debug it :-)