New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve install function #3247
Conversation
- BREAKING CHANGE: must Vue.use(Vuetify) when using CDN package - No longer includes the entire package.json in the dist - Vue version is checked in the Vuetify component, now works with a-la-carte too - $vuetify is a proper vue instance instead of the hacky defineReactive - Vuetify.version is now available to CDN users
Codecov Report
@@ Coverage Diff @@
## master #3247 +/- ##
==========================================
- Coverage 84.36% 84.35% -0.01%
==========================================
Files 145 145
Lines 3370 3369 -1
Branches 1074 1075 +1
==========================================
- Hits 2843 2842 -1
Misses 391 391
Partials 136 136
Continue to review full report at Codecov.
|
keeps backwards compat, but you can no longer apply options
src/components/Vuetify/index.js
Outdated
theme: theme(opts.theme), | ||
options: options(opts.options), | ||
goTo | ||
process.env.NODE_ENV !== 'test' && checkVueVersion(Vue) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why shouldn't we check vue version in test env?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the tests don't go through webpack, so each test dumps "Vuetify requires Vue version undefined" to the console.
reduces gzipped package size by 6.2kb compared to master
nuxt development broke when updating to 1.0.2 |
@ekoeryanto I confirm the error with the message: |
You can temporally resolve the issue by adding this to your const webpack = require('webpack')
…
module.exports = {
…
plugins: [
new webpack.DefinePlugin({
'process.env.REQUIRED_VUE': '"<your vue version>"'
// e.g. 'process.env.REQUIRED_VUE': '"2.5.13"'
})
]
} |
Thank you @beatgrabe . Worked for me. |
With webpack and an a-la-carte setup the same error happens with 1.0.2: vuetifyjs/a-la-carte#6 |
The related error is now fixed in v1.0.3 |
BREAKING CHANGE: mustVue.use(Vuetify)
when using CDN packageYou can now set the theme easily when using a CDNHow Has This Been Tested?
basic html file with markup from belowTypes of changes
Bug fix (non-breaking change which fixes an issue)Breaking change (fix or feature that would cause existing functionality to not work as expected)Checklist:
My change requires a change to the documentation.Markup