Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tabs): fixed twice emit input #3561

Merged
merged 1 commit into from Mar 19, 2018

Conversation

FFxSquall
Copy link
Contributor

@FFxSquall FFxSquall commented Mar 13, 2018

Description

Motivation and Context

#3560

How Has This Been Tested?

Markup:

<template>
  <v-app>
    <v-content>
      <v-tabs
        slider-color="yellow"
        v-model="model"
        @input="changeInput"
      >
        <v-tab
          v-for="i in 3"
          :key="i"
          :href="`#tab-${i}`"
        >
          Item {{ i }}
        </v-tab>
        <v-tab-item
          v-for="i in 3"
          :key="i"
          :id="`tab-${i}`"
        >
          <v-card flat>
            <v-card-text v-text="text"></v-card-text>
          </v-card>
        </v-tab-item>
      </v-tabs>
    </v-content>
  </v-app>
</template>
<script>
export default {
  data() {
    return {
      model: 'tab-2',
      text:
        'Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.',
    };
  },
  methods: {
    changeInput(val) {
      console.log(val);
    },
  },
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #3561 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3561   +/-   ##
=======================================
  Coverage   83.59%   83.59%           
=======================================
  Files         152      152           
  Lines        3523     3523           
  Branches     1107     1107           
=======================================
  Hits         2945     2945           
  Misses        430      430           
  Partials      148      148
Impacted Files Coverage Δ
src/components/VTabs/VTabs.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561331c...21ffdd4. Read the comment docs.

@johnleider johnleider added the T: bug Functionality that does not work as intended/expected label Mar 19, 2018
@johnleider johnleider added this to the Sprint 7 milestone Mar 19, 2018
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants