New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert components to typescript #3837
Conversation
39c93fa
to
4f0c70f
Compare
refactor: use Vue.extend instead of decorators
4f0c70f
to
ea47a6b
Compare
dbc4611
to
c237d22
Compare
effb61a
to
0a76ae9
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3837 +/- ##
==========================================
- Coverage 87.22% 87.19% -0.04%
==========================================
Files 154 158 +4
Lines 3782 3990 +208
Branches 1200 1272 +72
==========================================
+ Hits 3299 3479 +180
- Misses 371 396 +25
- Partials 112 115 +3
Continue to review full report at Codecov.
|
3b0d155
to
0d1e518
Compare
0d1e518
to
10c86d1
Compare
It may be just me, but it seems this work is pretty useless. |
I don't agree. Vue is compatible with TypeScript as well, but Vuetify was not entirely ready for that. This helps using the Vuetify framework in TypeScript enabled Vue projects and still have the possibility to import only components you need/use (a-la-carte), instead of having to import the entire set of components and corresponding styling, keeping the output files as small as possible. Ofcourse this is just a start and like Kael said, other components need to be converted, but I'm really happy this is happening. |
As long as using typescript remains optional I do agree.
I had the feeling that it would be NOT optional. |
This makes 0 difference to you unless you are working on vuetify itself. |
Description
This should be ready to go, I've got tests and builds working with no issues as far as I can tell, and it's actually smaller than the current dev build by ~8KB minified.
So far I've converted VIcon, VBtn, VbtnToggle, and a few mixins and helpers. Everything else can be done incrementally over time.
Possible component patterns:
Things to note:
SomeComponent.options
to access properties on the original object.Fixes #3943
Types of changes
TODO: