Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Centres pagination button text on iOS 9.3.5 #5208

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Fix: Centres pagination button text on iOS 9.3.5 #5208

merged 1 commit into from
Oct 24, 2018

Conversation

ryuhhnn
Copy link
Contributor

@ryuhhnn ryuhhnn commented Oct 2, 2018

Description

The current styles for .v-pagination__item are using display: inline-flex to centre the button text, which is actually unnecessary since button text is inheriting text-align: center. I removed the offending code and it seems to be rendering proper now on all devices.

Motivation and Context

Fixes #5016

How Has This Been Tested?

Tested visually using BrowserStack

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@johnleider
Copy link
Member

You need to rebase this.

@ryuhhnn
Copy link
Contributor Author

ryuhhnn commented Oct 8, 2018

My apologies for that @johnleider. Bug fix has been rebased appropriately.

@johnleider johnleider assigned johnleider and unassigned johnleider Oct 8, 2018
@johnleider johnleider self-requested a review October 8, 2018 15:31
@johnleider johnleider added T: bug Functionality that does not work as intended/expected pending review The issue is still pending disposition labels Oct 8, 2018
@johnleider johnleider removed the pending review The issue is still pending disposition label Oct 24, 2018
@johnleider johnleider merged commit 99d201b into vuetifyjs:master Oct 24, 2018
nekosaur pushed a commit that referenced this pull request Oct 26, 2018
@ryuhhnn @nekosaur
Resolves bug where certain iOS versions were causing left aligned pag…
83e653c 
…ination text in buttons (#5208)
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnleider johnleider johnleider approved these changes

Assignees
No one assigned
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] Pagination button text is not centered on iOS 9.3.5
2 participants
@ryuhhnn @johnleider