Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: VPagination acts as submit in forms (#5212) #5229

Merged
merged 4 commits into from
Oct 24, 2018
Merged

Fix: VPagination acts as submit in forms (#5212) #5229

merged 4 commits into from
Oct 24, 2018

Conversation

materight
Copy link
Contributor

Description

Currently v-pagination's buttons acts like submit buttons, so it's not possible to use v-pagination inside a form.

Motivation and Context

Fix #5212

How Has This Been Tested?

Tested locally with webpack

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@KaelWD
Copy link
Member

KaelWD commented Oct 5, 2018 •
edited 

git rebase --onto master HEAD~
git push -f

@johnleider
Copy link
Member

You also need to update unit tests

@materight
Copy link
Contributor Author

Done

@nekosaur nekosaur self-requested a review October 22, 2018 09:52
@johnleider johnleider merged commit cb29f21 into vuetifyjs:master Oct 24, 2018
nekosaur pushed a commit that referenced this pull request Oct 26, 2018
@materight @nekosaur
Fix: VPagination acts as submit in forms (#5212) (#5229)
c2f1174 
* Fix VPagination acting as submit

* Fixed double quotes

* Updated unit tests
@KaelWD KaelWD mentioned this pull request Dec 1, 2018
Closed
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnleider johnleider johnleider approved these changes

@nekosaur nekosaur Awaiting requested review from nekosaur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-pagination trigger v-form submit
3 participants
@materight @KaelWD @johnleider