Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-ripple): only modify position if current one is static #5249

Merged
merged 2 commits into from
Oct 10, 2018

Conversation

nekosaur
Copy link
Member

@nekosaur nekosaur commented Oct 9, 2018

Description

solves problems when using for example position sticky

Motivation and Context

closes #2573

How Has This Been Tested?

visually, playground

Markup:

<template>
  <v-app id="inspire">
    <v-content>
      <v-card ripple hover style="width:300px;margin:20px">
        <v-card-title>
          <div class="headline">awesome title</div>
        </v-card-title>
        <v-card-text>
          blueberry muffins are amazing!!!!
        </v-card-text>
      </v-card>

      <v-card ripple hover style="width:300px;margin:20px;position:static">
        <v-card-title>
          <div class="headline">awesome title</div>
        </v-card-title>
        <v-card-text>
          blueberry muffins are amazing!!!!
        </v-card-text>
      </v-card>

      <v-card ripple hover style="width:300px;margin:20px" class="static">
        <v-card-title>
          <div class="headline">awesome title</div>
        </v-card-title>
        <v-card-text>
          blueberry muffins are amazing!!!!
        </v-card-text>
      </v-card>

      <v-card ripple hover style="width:300px;margin:20px;position:absolute;left:200px">
        <v-card-title>
          <div class="headline">awesome title</div>
        </v-card-title>
        <v-card-text>
          blueberry muffins are amazing!!!!
        </v-card-text>
      </v-card>

      <v-card ripple hover style="width:300px;margin:20px" class="sticky">
        <v-card-title>
          <div class="headline">awesome title</div>
        </v-card-title>
        <v-card-text>
          blueberry muffins are amazing!!!!
        </v-card-text>
      </v-card>
      <br v-for="i in 100" :key="i">
    </v-content>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
    })
  }
</script>

<style>
  .v-card.static {
    position: static;
  }

  .v-card.sticky {
    position: sticky;
    top: 30px;
    left: 800px;
  }
</style>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #5249 into master will decrease coverage by 0.4%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5249      +/-   ##
==========================================
- Coverage   89.14%   88.73%   -0.41%     
==========================================
  Files         230      230              
  Lines        5474     5657     +183     
  Branches     1378     1449      +71     
==========================================
+ Hits         4880     5020     +140     
- Misses        475      499      +24     
- Partials      119      138      +19
Impacted Files Coverage Δ
src/directives/ripple.ts 40.21% <0%> (-1.83%) ⬇️
src/components/VDialog/VDialog.js 71.73% <0%> (-0.2%) ⬇️
src/components/VStepper/VStepperContent.js 100% <0%> (ø) ⬆️
src/components/VSelect/VSelect.js 88.31% <0%> (+0.05%) ⬆️
src/components/VStepper/VStepper.js 12.24% <0%> (+2.56%) ⬆️
src/components/VStepper/VStepperStep.js 71.11% <0%> (+3.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d7bc0...841c003. Read the comment docs.

@johnleider johnleider merged commit 85bfe20 into master Oct 10, 2018
@johnleider johnleider deleted the fix/ripple-position branch October 10, 2018 13:43
lzhoucs added a commit to lzhoucs/vuetify that referenced this pull request Oct 10, 2018
* Filter comments to count actual rendered elements

* Remove unnecesary conditional

* Filter out VNodes with empty text

* fix(VImg): allow transition to be disabled

* fix(v-combobox): update onEnterDown logic

should let v-select-list handle the update if user is selecting index

fixes vuetifyjs#5008

* fix(v-slider): remove duplicate change event

onMouseUp is already triggered by v-input, our mouseUp usage is more internal for slider, just
renamed method

fixes vuetifyjs#4996

* fix(v-combobox): prevent default action

when using a combobox, enter should be treated differently and not invoke a form submit

fixes vuetifyjs#4974

* fix(VMenu): make detached provide reactive

fixes vuetifyjs#5010

* fix(VBreadcrumbs): add Themeable classes

fixes vuetifyjs#4986

* Fix vuetifyjs#3904: dividers are not shown in dynamic vertical stepper (vuetifyjs#4767)

* Fix vuetifyjs#4696: Checkbox is hard to click with ripple disabled (vuetifyjs#4776)

* test(v-stepper-ccontent): add provide

* [release] 1.2.2

* V-Autocomplete: hide-no-data also controls opening menu upon item update

fixes vuetifyjs#4663

* fix(v-footer): fix applicationProperty update

add new value for inset footer to applicationable

fixes vuetifyjs#4686

* [release] 1.1.16

* [release] 1.2.3

* fix(VMenu): inherit light/dark from v-app

playground: https://pastebin.com/raw/jtLrtVtP

* fix(DatePicker): Title spacing when month === August (vuetifyjs#5027)

* fix(v-autocomplete): add conditional for single-line

fixes vuetifyjs#5076

* fix(v-list-tile-action): add support for v-html

fixes vuetifyjs#5037

* fix(v-navigation-drawer): pull in Dependent mixin for click-outside

* feat(v-carousel): convert to ts

* refactor(v-carousel): update review items

* chore(v-carousel): update type

* refactor(v-carousel): update feedback items

* feat(dependent): convert to ts

* feat(filterable): convert to ts

* feat(returnable): convert to ts

* feat(components-index): convert to ts

* feat(colorable): convert to ts

* refactor(colors.d.ts): move file

* fix(translatable): partially revert 5f661a3

reverted back to original logic to correct scrolling bug

fixes vuetifyjs#4847

* [release] 1.2.4

* style(v-pagination): button cutting the page number

When props:length is a very large number,
the number of the button protrudes.

# <type>: (If applied, this commit will...) <subject> (Max 50 char)
# |<----  Using a Maximum Of 50 Characters  ---->| Hard limit to 72 -->|

# Explain why this change is being made
# |<----   Try To Limit Each Line to a Maximum Of 72 Characters   ---->|

# Provide links to any relevant issues, articles, commits, or other
# pull requests
# Example: See #23, fixes vuetifyjs#58

# --- COMMIT END ---
# <type> can be
#    feat     (new feature)
#    fix      (bug fix)
#    refactor (refactoring production code)
#    style    (formatting, missing semi colons, etc; no code change)
#    test     (adding or refactoring tests; no production code change)
#    chore    (updating npm scripts etc; no production code change)
# --------------------
# Remember to
#    Capitalize the subject line
#    Use the imperative mood in the subject line
#    Do not end the subject line with a period
#    Separate subject from body with a blank line (comments don't count)
#    Use the body to explain what and why vs. how
#    Can use multiple lines with "-" for bullet points in body
#
# If you can't summarize your changes in a single line, they should
# probably be split into multiple commits
# --------------------
# For more information about this template, check out
# https://gist.github.com/adeekshith/cd4c95a064977cdc6c50

* fix(iterable): rows-per-page selector not inheriting theme

* [release] 1.2.5

* fix(VStepperStep): use colorable mixin

fixes vuetifyjs#5183

* test for vuetifyjs#5183

* Fix vuetifyjs#4760: show next pagination page if current page is last

* [release] 1.2.6

* fix(v-radio): remove bottom margin

if only or last child, do not add margin

fixes vuetifyjs#5162

* fix(v-autocomplete): allow setSearch for numeric 0

fixes vuetifyjs#5110

* [v-tab] Fix anchor hash routing (vuetifyjs#5124)

* fix(v-messages): change assigned key

fixes vuetifyjs#4880

* fix(v-select): remove change event for external changes

fixes vuetifyjs#5006

* fix(v-text-field): change mouseup focus to conditional

should only focus the input if the originating mousedown was on the element

fixes vuetifyjs#5018

* fix(VLinearProgress): invalid class applied when using css color

* fix(VEditDialog): apply theme classes to content (vuetifyjs#5152)

* fix(VEditDialog): apply theme classes to content

fixes vuetifyjs#5127

* test: update snapshots

* [release] 1.2.7

* fix(v-ripple): decrease click target size on selection control ripple (vuetifyjs#5250)

hopefully removes instances where click targets overlap between adjacent inputs

closes vuetifyjs#2661

* fix(v-stepper): add registrable mixin

fixes vuetifyjs#3330

* fix(v-select): change isDisabled conditional

should use regular text color when readonly

fixes vuetifyjs#5051

* fix(v-dialog): always remove scrollbar when fullscreen

fixes vuetifyjs#3101

* fix(v-ripple): only modify position if current one is static (vuetifyjs#5249)

* fix(v-ripple): only modify position if current one is static

solves problems when using for example position sticky

closes vuetifyjs#2573

* chore(ripple): ignore eslint for max-statements

* [release] 1.2.8
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ripple directive sets/unsets position
2 participants