Fix #5316

[haggys22]

In 24hr mode, when clicking on the left part of 12, 23 was selected

Description

For the edge case on an insideClick, instead of selecting this.max (i.e. 23), this.max - this.roundCount + 1 (i.e. 23 - 12 + 1 = 12) is selected

Motivation and Context

Fixes #5316

How Has This Been Tested?

Tested manually, no test have been added

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

• The PR title is no longer than 64 characters.
• The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have created a PR in the documentation with the necessary changes.

[jacekkarczmarczyk]

Looks good @haggys22 , please only update the unit test

diff --git a/test/unit/components/VTimePicker/VTimePickerClock.spec.js b/test/unit/components/VTimePicker/VTimePickerClock.spec.js
index d8f5f141..3756c6ed 100644
--- a/test/unit/components/VTimePicker/VTimePickerClock.spec.js
+++ b/test/unit/components/VTimePicker/VTimePickerClock.spec.js
@@ -218,6 +218,8 @@ test('VTimePickerClock.js', ({ mount }) => {
     finger.move(120, 0)
     expect(input).toBeCalledWith(0)
     finger.move(135, 90)
+    expect(input).toBeCalledWith(4)
+    finger.move(90, 135)
     expect(input).toBeCalledWith(7)
   })
 })

[codecov]

Codecov Report

Merging #5317 into master will increase coverage by 0.6%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #5317     +/-   ##
=========================================
+ Coverage   89.11%   89.72%   +0.6%     
=========================================
  Files         230      246     +16     
  Lines        5486     5830    +344     
  Branches     1386     1455     +69     
=========================================
+ Hits         4889     5231    +342     
- Misses        475      476      +1     
- Partials      122      123      +1

Impacted Files	Coverage Δ
src/components/VTimePicker/VTimePickerClock.js	100% <100%> (ø)	⬆️
src/components/VTabs/mixins/tabs-watchers.js	84.61% <0%> (-15.39%)	⬇️
src/directives/ripple.ts	34.51% <0%> (-5.71%)	⬇️
src/components/VBtn/VBtn.ts	96.87% <0%> (-3.13%)	⬇️
src/components/VTabs/VTab.js	96.42% <0%> (-0.45%)	⬇️
src/components/VInput/VInput.js	95.52% <0%> (-0.07%)	⬇️
src/mixins/routable.ts	100% <0%> (ø)	⬆️
src/components/VTabs/VTabsItems.js	100% <0%> (ø)	⬆️
.../components/VProgressCircular/VProgressCircular.ts	100% <0%> (ø)	⬆️
src/components/VTimePicker/VTimePicker.js	95.71% <0%> (ø)	⬆️
... and 46 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08b67a7...d9315d0. Read the comment docs.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord