Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VListGroup): text overflow #5451

Merged
merged 1 commit into from Nov 1, 2018

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #3038

How Has This Been Tested?

visually

Markup:

<template>
  <v-app id="inspire">
    <v-content>
      <v-container>
        <v-card style="width: 200px">
          <v-list>
            <v-list-group>
              <v-list-tile slot="activator">
                <v-list-tile-content>
                  <v-list-tile-title>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</v-list-tile-title>
                </v-list-tile-content>
              </v-list-tile>
              <v-list-tile>
                <v-list-tile-content>
                  <v-list-tile-title>
                    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
                  </v-list-tile-title>
                </v-list-tile-content>
              </v-list-tile>
            </v-list-group>

            <v-list-group prepend-icon="check">
              <v-list-tile slot="activator">
                <v-list-tile-content>
                  <v-list-tile-title>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</v-list-tile-title>
                </v-list-tile-content>
              </v-list-tile>
              <v-list-tile>
                <v-list-tile-content>
                  <v-list-tile-title>
                    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
                  </v-list-tile-title>
                </v-list-tile-content>
              </v-list-tile>
            </v-list-group>

            <v-list-group no-action>
              <v-list-tile slot="activator">
                <v-list-tile-content>
                  <v-list-tile-title>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</v-list-tile-title>
                </v-list-tile-content>
              </v-list-tile>
              <v-list-tile>
                <v-list-tile-content>
                  <v-list-tile-title>
                    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
                  </v-list-tile-title>
                </v-list-tile-content>
              </v-list-tile>
            </v-list-group>

            <v-list-group prepend-icon="check" no-action>
              <v-list-tile slot="activator">
                <v-list-tile-content>
                  <v-list-tile-title>aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa</v-list-tile-title>
                </v-list-tile-content>
              </v-list-tile>
              <v-list-tile>
                <v-list-tile-content>
                  <v-list-tile-title>
                    aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
                  </v-list-tile-title>
                </v-list-tile-content>
              </v-list-tile>
            </v-list-group>

          </v-list>
        </v-card>
      </v-container>
    </v-content>
  </v-app>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have created a PR in the documentation with the necessary changes.

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Oct 26, 2018
@KaelWD KaelWD added the S: has merge conflicts The pending Pull Request has merge conflicts label Oct 29, 2018
@jacekkarczmarczyk jacekkarczmarczyk removed the S: has merge conflicts The pending Pull Request has merge conflicts label Oct 29, 2018
@johnleider johnleider added this to the v1.3.x milestone Nov 1, 2018
@jacekkarczmarczyk jacekkarczmarczyk merged commit 8bd9ce1 into master Nov 1, 2018
@jacekkarczmarczyk jacekkarczmarczyk deleted the fix/#3038-v-list-group-overflow branch November 1, 2018 15:23
@codecov
Copy link

codecov bot commented Nov 1, 2018

Codecov Report

Merging #5451 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5451      +/-   ##
==========================================
- Coverage   88.97%   88.93%   -0.04%     
==========================================
  Files         262      262              
  Lines        5885     5885              
  Branches     1458     1457       -1     
==========================================
- Hits         5236     5234       -2     
- Misses        526      528       +2     
  Partials      123      123
Impacted Files Coverage Δ
packages/vuetify/src/components/VTabs/VTabs.js 97.43% <0%> (-2.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50dd6a4...781fa2f. Read the comment docs.

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-Report] V-list-group doesn't cut a long v-list-tile-title
3 participants