-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VGrid): pass down data-* attributes #6208
Conversation
This pull request is automatically deployed with Now. |
I haven't added any documentation changes. I will check what exists |
Codecov Report
@@ Coverage Diff @@
## dev #6208 +/- ##
==========================================
- Coverage 82.56% 82.55% -0.01%
==========================================
Files 293 293
Lines 7019 7023 +4
Branches 1726 1727 +1
==========================================
+ Hits 5795 5798 +3
- Misses 1089 1090 +1
Partials 135 135
Continue to review full report at Codecov.
|
I don't think there is a place when we mention it, the best would https://vuetifyjs.com/en/framework/grid |
@posva Thanks! |
Should I add some documentation tip in the page you mentioned or do you
prefer to merge it and do it your way?
|
Would say add a documentation tip on the grid page jacek mentions, and should be good. |
Ok! Will do it today probably |
Allow usage of data attributes like data-test="container" which are useful for testing and can be removed via vue-loader plugins
ffd8b99
to
a810d73
Compare
Added the docs, that was much harder than expected 😓 It isn't easy to understand the json data structure that generates the documentation. I also had this error all along: |
@posva still working on improving structure. if you need assistance on navigating them, reach out to me on discord. ill take a look at this when i get home later 👍 great work. |
Description
Allow usage of data attributes like data-test="container" which are useful for testing and can be
removed via vue-loader plugins
Motivation and Context
fixes #3404
This allows usage of
<v-layout data-test="foo"></v-layout>
to then find them in tests withwrapper.find('[data-test=foo]')
without needing to add extra classes that aren't used by any css. These attributes can be removed automatically so they do not exist in production code with a vue-loader plugin. There is a vue-cli plugin https://github.com/LinusBorg/vue-cli-plugin-test-attrsHow Has This Been Tested?
unit
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).