Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prevent content shifting during loading (ssr hydration) #6269

Merged
merged 1 commit into from
Jan 27, 2019
Merged

docs: prevent content shifting during loading (ssr hydration) #6269

merged 1 commit into from
Jan 27, 2019

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Jan 26, 2019

Description

In server-side rendered html for documentation pages (like /buttons) both left and right navigation drawers are hidden and content is horizantolly centered and has max-width: 1185px. (It can be checked by disabling javascript). Here is screenshot:
image

But after ssr hydradation both navigation drawers become visible. Left navigation drawer has width 300px and right has width 210px. Because navigation drawers has different widths, after hydradation content is shifting a bit (up to 45px). Here is screenshot:
image

This pr explicitly set horizontal padding for content to match padding after hydration.

Motivation and Context

A little smoother loading of the documentation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Jan 26, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community. 👍

@MajesticPotatoe MajesticPotatoe merged commit 6c62d8d into vuetifyjs:master Jan 27, 2019
@dima74
Copy link
Contributor Author

dima74 commented Jan 27, 2019

Yes, thank you, I have already joined

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants