Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(kitchen): use new slot syntax #6525

Merged
merged 3 commits into from Feb 25, 2019
Merged

refactor(kitchen): use new slot syntax #6525

merged 3 commits into from Feb 25, 2019

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Feb 17, 2019

Description

Use new slot syntax in kitchen

Motivation and Context

New Vue slot syntax

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@dsseng dsseng added T: enhancement Functionality that enhances existing features kitchen Related to kitchen labels Feb 17, 2019
@dsseng dsseng added this to the v2.0.0 milestone Feb 17, 2019
@dsseng dsseng self-assigned this Feb 17, 2019
@vercel vercel bot requested a deployment to staging February 25, 2019 18:43 Abandoned
@vercel vercel bot requested a deployment to staging February 25, 2019 18:43 Abandoned
@dsseng dsseng merged commit 07aa490 into next Feb 25, 2019
@dsseng dsseng deleted the style/kitchen-slots branch February 25, 2019 18:43
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnleider johnleider johnleider approved these changes

@jacekkarczmarczyk jacekkarczmarczyk Awaiting requested review from jacekkarczmarczyk

@KaelWD KaelWD Awaiting requested review from KaelWD

@peluprvi peluprvi Awaiting requested review from peluprvi

Assignees

@dsseng dsseng

Labels
kitchen Related to kitchen T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dsseng @peluprvi @johnleider @jacekkarczmarczyk @KaelWD