Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VTreeview): **rounded**/**shaped** props #7616

Merged
merged 2 commits into from
Jun 24, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #7614

How Has This Been Tested?

playground

Markup:

<template>
  <div class="ma-5 pa-5">
    <v-treeview v-model="selected" rounded :active="selected" :items="treeItems" color="primary" activatable selectable hoverable />
    <v-divider />
    <v-treeview :items="treeItems" shaped color="red" activatable hoverable open-on-click />
  </div>
</template>

<script>
  export default {
    data: () => ({
      selected: [],
      treeItems: [
          {
            id: 1,
            name: 'Applications:',
            children: [
              { id: 2, name: 'Calendar' },
              {
                id: 3,
                name: 'Chrome',
                children: [
                  { id: 4, name: 'Foo', disabled: true },
                  { id: 5, name: 'Bar' },
                  { id: 6, name: 'Baz' }
                ],
              },
              { id: 7, name: 'Webstorm' }
            ]
          },
          {
            id: 8,
            name: 'Also applications:',
            disabled: true,
            children: [
              { id: 9, name: 'Calendar' },
              { id: 357, name: 'Chrome' },
            ]
          },
        ]
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk changed the title feat(VTreeview): rounded/shaped props feat(VTreeview): **rounded**/**shaped** props Jun 21, 2019
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Jun 21, 2019
@jacekkarczmarczyk jacekkarczmarczyk added the T: feature A new feature label Jun 21, 2019
Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add docs examples?

@jacekkarczmarczyk
Copy link
Member Author

I'd prefer to add them to the new structure (#7641) to avoid possible merging conflicts. So either I'll update 7641 after merging this PR or I'll add docs to this PR after merging 7641

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #7616 into next will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7616      +/-   ##
==========================================
+ Coverage   86.93%   86.93%   +<.01%     
==========================================
  Files         326      326              
  Lines        8540     8536       -4     
  Branches     2154     2153       -1     
==========================================
- Hits         7424     7421       -3     
+ Misses       1026     1025       -1     
  Partials       90       90
Impacted Files Coverage Δ
.../vuetify/src/components/VTreeview/VTreeviewNode.ts 98.66% <ø> (ø) ⬆️
...es/vuetify/src/components/VDataTable/VDataTable.ts 84.24% <0%> (-0.19%) ⬇️
packages/vuetify/src/util/helpers.ts 91.79% <0%> (-0.05%) ⬇️
...es/vuetify/src/components/VSparkline/VSparkline.ts 73.14% <0%> (ø) ⬆️
packages/vuetify/src/components/VInput/VInput.ts 97.18% <0%> (ø) ⬆️
...uetify/src/components/VCheckbox/VSimpleCheckbox.ts 90.47% <0%> (+4.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b233df...412f9bd. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 24, 2019

Codecov Report

Merging #7616 into next will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7616      +/-   ##
==========================================
+ Coverage   86.93%   86.94%   +0.01%     
==========================================
  Files         326      326              
  Lines        8540     8540              
  Branches     2154     2154              
==========================================
+ Hits         7424     7425       +1     
+ Misses       1026     1025       -1     
  Partials       90       90
Impacted Files Coverage Δ
.../vuetify/src/components/VTreeview/VTreeviewNode.ts 98.66% <ø> (ø) ⬆️
packages/vuetify/src/components/VSelect/VSelect.ts 93.4% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b233df...412f9bd. Read the comment docs.

@dsseng dsseng merged commit acfdef7 into next Jun 24, 2019
@dsseng dsseng deleted the feat/#7614-treeview-rounded-shaped branch June 24, 2019 09:20
@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants