fix: cleanup the codes

vueup · Mar 29, 2021 · 9895952 · 9895952
1 parent 7929e69
commit 9895952
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 155 deletions.
diff --git a/packages/vue-quill/src/assets/snow.styl b/packages/vue-quill/src/assets/snow.styl
@@ -5,7 +5,7 @@ backgroundColor = #fff
 inactiveColor = #4B5563
 shadowColor = #D1D5DB
 textColor = #4B5563
-// Additional color
+// Additional colors
 backgroundHoverColor = #F3F4F6
 backgroundActiveColor = #DBEAFE
 

diff --git a/scripts/build.ts b/scripts/build.ts
@@ -13,7 +13,7 @@ npm run build -- vue-quill
 npm run build -- vue-quill --formats cjs
 ```
 */
-(() => {
+(async () => {
   const fs = require('fs-extra')
   const path = require('path')
   const execa = require('execa')
@@ -41,7 +41,7 @@ npm run build -- vue-quill --formats cjs
   const commit =
     args.commit || execa.sync('git', ['rev-parse', 'HEAD']).stdout.slice(0, 7)
 
-  run()
+  await run()
 
   async function run() {
     if (isRelease) {
@@ -102,8 +102,17 @@ npm run build -- vue-quill --formats cjs
 
     if (hasTypes && pkg.types) await generateTypes(target)
     if (buildAssets && assets.css) {
-      const buildAssetsRunner = path.resolve(__dirname, 'buildAssets.ts')
-      await execa('npx', ['ts-node', buildAssetsRunner, target])
+      const buildAssetsTs = await path.resolve(__dirname, 'buildAssets.ts')
+      await execa(
+        'npx',
+        [
+          'ts-node',
+          buildAssetsTs,
+          target,
+          isRelease ? '--release' : ''
+        ],
+        { stdio: 'inherit' }
+      )
     }
   }
 

diff --git a/scripts/buildAssets.ts b/scripts/buildAssets.ts
@@ -7,7 +7,7 @@ To specify the package assets to build, simply pass its name
 npm run assets:build -- vue-quill
 ```
 */
-(() => {
+(async () => {
   const fs = require('fs-extra')
   const path = require('path')
   const chalk = require('chalk')
@@ -29,10 +29,8 @@ npm run assets:build -- vue-quill
   // const nextVersion: string =
   //   args.nextVersion ||
   //   require(path.resolve(__dirname, '..', 'package.json')).version
-  // const commit: string =
-  //   args.commit || execa.sync('git', ['rev-parse', 'HEAD']).stdout.slice(0, 7)
 
-  run()
+  await run()
 
   async function run() {
     if (isRelease) {

diff --git a/scripts/dev.ts b/scripts/dev.ts
@@ -15,7 +15,7 @@ npm run dev -- vue-quill --formats cjs
 __DEV__=false npm run dev
 ```
 */
-(() => {
+(async () => {
   const execa = require('execa')
   const { fuzzyMatchTarget } = require('./utils')
 
@@ -26,7 +26,7 @@ __DEV__=false npm run dev
   const sourceMap: boolean = args.sourcemap || args.s
   const commit = execa.sync('git', ['rev-parse', 'HEAD']).stdout.slice(0, 7)
 
-  execa(
+  await execa(
     'rollup',
     [
       '-wc',

diff --git a/scripts/devAssets.ts b/scripts/devAssets.ts
@@ -7,7 +7,7 @@ To specify the package to build, simply pass its name
 npm run assets:build -- vue-quill
 ```
 */
-(() => {
+(async () => {
   const fs = require('fs-extra')
   const path = require('path')
   const chalk = require('chalk')
@@ -24,7 +24,7 @@ npm run assets:build -- vue-quill
   const isRelease: boolean = args.release
   const buildAllMatching: string[] = args.all || args.a
 
-  run()
+  await run()
 
   async function run() {
     if (isRelease) {

diff --git a/scripts/preRelease.ts b/scripts/preRelease.ts
diff --git a/scripts/release.ts b/scripts/release.ts
@@ -19,7 +19,9 @@
       [
         '@semantic-release/exec',
         {
-          prepareCmd: `npx ts-node ../../scripts/build.ts --nextVersion \$\{nextRelease.version\} && zip ${target}-dist.zip -r dist`,
+          prepareCmd:
+            'npx ts-node ../../scripts/build.ts --nextVersion \$\{nextRelease.version\} && ' +
+            `zip ${target}-dist.zip -r dist`
         }
       ],
       '@semantic-release/npm',
@@ -38,7 +40,7 @@
     ]
   }
 
-  run()
+  await run()
 
   async function run() {
     const pkgDir = path.resolve(__dirname, `../packages/${target}`)