Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: using nuxt@latest #142

Closed
cpreston321 opened this issue Oct 18, 2022 · 1 comment
Closed

bug: using nuxt@latest #142

cpreston321 opened this issue Oct 18, 2022 · 1 comment

Comments

@cpreston321
Copy link

Error Context

Nuxi 3.0.0-rc.12-27768075.6567ac3                                                                                                           
ℹ Node.js version: 18.9.0                                                                                                                    11:25:27
ℹ Preset: node-server                                                                                                                        11:25:27
ℹ Working dir: .output                                                                                                                       11:25:27
ℹ Loading .env. This will not be loaded when running the server in production.                                                               11:25:27
ℹ Starting preview command: node ./server/index.mjs                                                                                          11:25:27
                                                                                                                                             11:25:27
Listening http://[::]:3000
lang en-US
hasTransition true
[nuxt] [request error] [unhandled] [500] str.replace is not a function
  at sanitiseAttrValue (./server/chunks/app/server.mjs:749:7)  
  at renderHeadToString (./server/chunks/app/server.mjs:795:47)  
  at nuxtApp.ssrContext.renderMeta (./server/chunks/app/server.mjs:1259:27)  
  at ./server/chunks/handlers/renderer.mjs:418:53  
  at async ./server/chunks/handlers/renderer.mjs:59:22  
  at async Object.handler (./server/node_modules/h3/dist/index.mjs:566:19)  
  at async Server.toNodeHandle (./server/node_modules/h3/dist/index.mjs:630:7)

I was diving deeper into the chunks on the server side and saw that renderHeadToString() was trying to sanitize a boolean value.

Note
This only happens when I built the project and try to preview.

Here is the code I was logging to trace the error

var renderHeadToString = async (head) => {
    ....
    for (const k in tag.props) {
       console.log(k, tag.props[k]);
       attrs[tag.tag][sanitiseAttrName(k)] = sanitiseAttrValue(tag.props[k]);
     }
     ....
}
     
var sanitiseAttrValue = (str) => escapeJS(
 str.replace(/"/g, "&quot;").replace(/</g, "&lt;").replace(/>/g, "&gt;")
);

What I see when I preview

image

@harlan-zw
Copy link
Collaborator

Fixed in #143, available in v1.0.0-rc.11

harlan-zw added a commit that referenced this issue Nov 12, 2022
* refactor!: v1 initial, CSR performance, awaitable hooks (#126)

* performance: rewrite reactivity for SSR / CSR

* chore: rolleback artifacts

* chore: progress commit

* fix: use ./src import

* refactor!: simplify utils for smaller pkg (#127)

* performance: rewrite reactivity for SSR / CSR

* chore: rolleback artifacts

* chore: progress commit

* fix: use ./src import

* refactor: simplify util code for smaller payload

* refactor!: continued (#128)

* performance: rewrite reactivity for SSR / CSR

* chore: rolleback artifacts

* chore: progress commit

* fix: use ./src import

* refactor: simplify util code for smaller payload

* wip: part two of refactor

* chore: fix tests

* chore: run github ci on v1

* chore: run github ci on v1

* chore: bump version

* Release v1.0.0-rc.0

* Release v1.0.0-rc.1

* fix: ensure empty attrs reset attrs (#130)

* fix: ensure empty attr is set

* fix: test valid tags

* fix(ci): release on rc

* Release v1.0.0-rc.2

* fix(ci): remove broken --pre

* Release v1.0.0-rc.3

* fix(ci): use --pre

* fix: use simpler API for tags (#131)

* feat: improved hook api (#132)

* chore: prefer runtime prop for id & position (#134)

* chore: prefer runtime prop for id & position

* fix: type errors

* fix: add `headTags` for backwards compatibility (#133)

* Release v1.0.0-rc.4

* fix: add legacy `addHeadObjs` (#135)

* refactor!: useHeadRaw -> useHeadSafe (#136)

* refactor!: useHeadRaw -> useHeadSafe

* feat: tree-shake encoding

* chore: useHeadSafe types

* Release v1.0.0-rc.5

* fix(types): export `MaybeComputedRef`

* chore: add missing `type`

* Release v1.0.0-rc.6

* chore(pkg): bump deps

* fix(titleTemplate): allow titleTemplate to resolve the title (#137)

* fix(titleTemplate): allow titleTemplate to resolve the title

* chore: add happy case

* chore: fix type issues

* chore: maybe fix type issue

* chore: maybe fix type issue

* chore: maybe fix type issue

* chore: maybe fix type issue

* Release v1.0.0-rc.7

* chore: bump deps

* chore: test issue #138

* chore: linting

* chore(pkg): bump deps

* Release v1.0.0-rc.8

* fix: ensure tags props are immutable (#139)

* Release v1.0.0-rc.9

* chore(pkg): bump deps

* Release v1.0.0-rc.10

* fix: ensure single pass of `htmlAttr` sanitization, fixes #142 (#143)

* fix: ensure csr elements are created equally (#145)

* fix: ensure csr elements are created equally

* fix: remove sanitising

* chore: fix doc

* chore(pkg): bump deps

* Release v1.0.0-rc.11

* fix: vue 2.7 globalProperties, fixes #141

* chore(pkg): bump zhead

* Release v1.0.0-rc.12

* add vue 2.7 compatibility to Head component (#147)

* add vue 2.7 compatibility to Head component

* remove vue-demi in favor of checking version from vue itself

* chore(pkg): bump deps

* fix: dedupe `htmlAttrs` and `bodyAttrs` for csr (#149)

* Release v1.0.0-rc.13

* fix: Vue 2.7 compatibility (#150)

* add separate vue2 plugin for 2.7 compatibility

* Vue 2.7 install readme

* fix: handle style / class attrs

* chore: add link back to pinia

* chore: vue2 example

Co-authored-by: Val Trubachev <val.trubachev@zoro.com>

* chore(pkg): ignore eslint in vue2 example

* Release v1.0.0-rc.14

* feat: migrate core to unhead (#157)

* feat: migrate core to unhead

* chore: fix SSR test with timeouts

* chore: readme link fix

* chore(pkg): bump deps

* chore(ci): switch to next channel

* chore: document install

* Release v1.0.0-next.1

* chore: improve doc

* chore: bump unhead, update tests and examples

* Release v1.0.0-next.2

* chore: bump unhead

* chore: expose `VueHeadMixin`

* Release v1.0.0-next.3

Co-authored-by: Valera Trubachev <vetruvet@gmail.com>
Co-authored-by: Val Trubachev <val.trubachev@zoro.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants