Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make document of updateDOM configurable #7

Merged
merged 1 commit into from
Jan 19, 2021
Merged

feat: make document of updateDOM configurable #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export type Head = {

removeHeadTags: (tags: HeadTag[]) => void

updateDOM: () => void
updateDOM: (document?: Document) => void
}

export interface HTMLResult {
Expand Down Expand Up @@ -126,7 +126,7 @@ const setAttrs = (el: Element, attrs: HeadAttrs) => {
el.setAttribute(HEAD_ATTRS_KEY, keys.join(','))
}

const insertTags = (tags: HeadTag[]) => {
const insertTags = (tags: HeadTag[], document = window.document) => {
const head = document.head
let headCountEl = head.querySelector(`meta[name="${HEAD_COUNT_KEY}"]`)
const headCount = headCountEl
Expand Down Expand Up @@ -234,8 +234,8 @@ export const createHead = () => {
})
},

updateDOM() {
insertTags(headTags)
updateDOM(document) {
insertTags(headTags, document)
},
}
return head
Expand Down