Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leaving hovered state when pointer hovers child element #194

Merged
merged 1 commit into from
May 29, 2024

Conversation

BobbieGoede
Copy link
Collaborator

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #191

As we are using the 'mouseout' event to detect whether a motion should leave the hovered state it would also get triggered when hovering a child element.

From what I can tell the 'mouseleave' event should be sufficient for this, are there possible use cases for using 'mouseout'?

I'm not quite sure if the test I added will be stable (not flaky) as it uses timeouts to check if the variant/state remains unchanged, this may need to be improved.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have added tests (if possible).
  • I have updated the documentation accordingly.

@BobbieGoede BobbieGoede self-assigned this May 29, 2024
@Tahul
Copy link
Member

Tahul commented May 29, 2024

well; I think variant feature itself uses timeouts in the background, so using it for testing seems equally okay. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover on nested element removes "hovered" styles
2 participants