-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event schema node development? #8
Comments
Hey @cyruscollier I'm on leave at the moment, happy to look into this when I'm back and settled (2 weeks) Otherwise please free to submit a PR 🙂 |
Thanks, @harlan-zw . I've started a PR: I tried to be as thorough as I could implementing all of the related specs required to build Event, but I only went 1-2 levels deep in most cases to cover interfaces that might be commonly used in the future, so it's not perfect. I still need to add good tests for the new nodes, which I will try and get to in the next week, but I thought I'd open the PR now to at least get a conversation going if this is a good direction for these additions. |
Hey @cyruscollier Sorry for the long lead time on this, I've just finished up v1 with the Event node included Going to close this off, but if you any issues or such please re-open. Thanks again for the contribution! |
Awesome! |
Does anyone have an idea of when the Event node will be available in this library? The docs say it's in development, but I don't see it anywhere in the repo. I need to implement the Event schema in a Nuxt 3 app that's going into production soon. If work hasn't begun on it yet, I'd be happy to implement Event myself and submit a PR for it. It doesn't look too time-consuming to add the spec and test files for a new schema node.
The text was updated successfully, but these errors were encountered: