feat: Event Schema.org node

[cyruscollier]

No description provided.

[harlan-zw]

Hey @cyruscollier

Thanks so much for this, it's an amazing PR with a lot of thought and effort put into it.

Starting with the changes in types.ts I think you may have missed the direction I wanted this package to have, though I can definitely appreciate why you've done it this way.

I purposely avoided implementing types from schema-dts. I've discussed why I went this route in this comment and the docs

Mainly I wanted to provide a simple API for end-users, only typing fields that Google has documented will affect Rich Results. In my opinion, the setup you have isn't a very nice DX and adds maintenance debt keeping things in sync with schema-dts.

End users who want to implement full typescript support on schema can make use of custom schema. Though the schema-dts usage still needs to be documented.

So to move forward with this PR, I'd like to see:

• CreativeWork dropped. Since it doesn't have a Google Rich Result mapping, is there a point in implementing it? More appropriate nodes would be Book and Movie. Additionally, it would be better suited as a separate PR (unless Event depends on it?). Again if people want to implement this type of Schema it's better suited as custom schema.
• The Event schema implements only the fields listed here https://developers.google.com/search/docs/advanced/structured-data/event#structured-data-type-definitions
• The verbose fields added to the root schema removed

From there it would be a lot easier to provide more granular feedback.

Again I truly appreciate the effort in this PR and if you disagree with anything I've said, please let me know.

[cyruscollier]

Thanks @harlan-zw , your feedback makes a lot of sense, especially about keeping the DX simple and only implementing what's supported by Google Structured Data. I'm actually a little relieved because I felt like I was starting to go down a rabbit hole trying to flush out the full Schema.org specs!

I've removed CreativeWork and Place as root nodes, and now Place is just a simple dependent interface as part of Event, although it may need to be moved into the shared types file if other nodes need it in the future.

[cyruscollier]

Hey @harlan-zw , any feedback on this revised PR? Thanks!

[harlan-zw]

Hey @cyruscollier

Thanks for the update to the PR! Sorry I missed this notification somehow, I'll give it a look this weekend and try get it merged!

[harlan-zw]

Thanks again @cyruscollier. I'm working on a major upgrade to this package and moving the node logic to https://github.com/harlan-zw/schema-org-graph

I'll migrate these changes, they'll be available in a beta that I'll push out today hopefully