Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vue instance provided to install() function is being ignored #184

Closed
sebagnz opened this issue Aug 9, 2022 · 2 comments · Fixed by #185
Closed

Vue instance provided to install() function is being ignored #184

sebagnz opened this issue Aug 9, 2022 · 2 comments · Fixed by #185

Comments

@sebagnz
Copy link
Contributor

sebagnz commented Aug 9, 2022 •
edited

vue-demi/lib/v2/index.mjs

Line 7 in 2f80cd7

Vue.use(VueCompositionAPI)

Should't it be?

_vue.use(VueCompositionAPI)

Otherwise vue-demi is always installing the composition api in the same vue instance.
@antfu
Copy link
Member

antfu commented Aug 10, 2022

Yeah nice catch, pr welcome

@sebagnz
Copy link
Contributor Author

sebagnz commented Aug 10, 2022

Sure, here it goes 👍 #185

@antfu antfu mentioned this issue Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(<2.7): Install composition API on provided vue instance
2 participants
@antfu @sebagnz