fix(useRouteParams): support optional params (#3934)

vueuse · May 27, 2024 · 4a88231 · 4a88231
1 parent c2f9295
commit 4a88231
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/router/useRouteParams/index.test.ts b/packages/router/useRouteParams/index.test.ts
@@ -90,6 +90,16 @@ describe('useRouteParams', () => {
     expect(lang.value).toBe('pt-BR')
   })
 
+  // docs @see https://router.vuejs.org/guide/essentials/route-matching-syntax.html#Optional-parameters
+  it('should return default value when use vue-router optional parameters', () => {
+    let route = getRoute({ page: '' })
+    const router = { replace: (r: any) => route = r } as any
+
+    const page: Ref<any> = useRouteParams('page', 'default', { route, router })
+
+    expect(page.value).toBe('default')
+  })
+
   it('should reset state on scope dispose', async () => {
     let route = getRoute()
     const router = { replace: (r: any) => route = r } as any

diff --git a/packages/router/useRouteParams/index.ts b/packages/router/useRouteParams/index.ts
@@ -56,7 +56,7 @@ export function useRouteParams<
       get() {
         track()
 
-        return transform(param !== undefined ? param : toValue(defaultValue))
+        return transform(param !== undefined && param !== '' ? param : toValue(defaultValue))
       },
       set(v) {
         if (param === v)