fix: update linter rule, close #729

.eslintrc.js

@@ -11,33 +11,36 @@ module.exports = {
     'jest',
   ],
   rules: {
-    'no-alert': 'off',
-    '@typescript-eslint/no-var-requires': 'off',
-    '@typescript-eslint/no-empty-function': 'off',
-    '@typescript-eslint/no-unused-vars': 'off',
-    'unicorn/prevent-abbreviations': 'off',
-    'unicorn/consistent-function-scoping': 'off',
-    'unicorn/no-null': 'off',
-    'unicorn/filename-case': 'off',
-    'react/react-in-jsx-scope': 'off',
     'react/no-string-refs': 'off',
-    'no-new': 'off',
-    'import/named': 'off',
     'react/no-unknown-property': 'off',
     'vue/no-deprecated-functional-template': 'off',
     'vue/one-component-per-file': 'off',
     'vue/no-template-shadow': 'off',
     'vue/require-prop-types': 'off',
-    'spaced-comment': ['error', 'always', { exceptions: ['@__PURE__'] }],
+    'spaced-comment': ['error', 'always', { exceptions: ['#__PURE__'] }],
+    'no-restricted-imports': [
+      'error',
+      {
+        paths: ['vue', '@vue/composition-api'],
+      },
+    ],
   },
   overrides: [
     {
-      files: ['*.md', 'demo.vue', 'scripts/*.ts'],
+      files: ['*.md', 'demo.vue', 'scripts/*.ts', '*.test.ts'],
       rules: {
+        'no-alert': 'off',
         'no-console': 'off',
         'no-undef': 'off',
         'no-unused-vars': 'off',
         '@typescript-eslint/no-unused-vars': 'off',
+        'no-restricted-imports': 'off',
+      },
+    },
+    {
+      files: ['packages/.vitepress/**/*.*'],
+      rules: {
+        'no-restricted-imports': 'off',
       },
     },
   ],

packages/.vitepress/config.js

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 // @ts-check
 require('esbuild-register')
 const indexes = require('../../indexes.json')

packages/.vitepress/theme/components/SideBarLink.ts

@@ -1,4 +1,5 @@
-import { FunctionalComponent, h, VNode } from 'vue'
+import { h } from 'vue'
+import type { VNode, FunctionalComponent } from 'vue'
 import { useRoute, useData } from 'vitepress'
 import { DefaultTheme } from '../config'
 import { joinUrl, isActive } from '../utils'

packages/.vitepress/theme/composables/navLink.ts

@@ -1,4 +1,5 @@
-import { computed, Ref } from 'vue'
+import { computed } from 'vue'
+import type { Ref } from 'vue'
 import { useRoute, withBase } from 'vitepress'
 import { isExternal as isExternalCheck } from '../utils'
 import type { DefaultTheme } from '../config'

packages/.vitepress/theme/composables/repo.ts

@@ -38,7 +38,7 @@ function getRepoText(url: string, text?: string): string {
   if (!hosts)
     return 'Source'
 
-  const platform = platforms.find(([_p, re]) => re.test(hosts[0]))
+  const platform = platforms.find(([, re]) => re.test(hosts[0]))
 
   if (platform && platform[0])
     return platform[0]

packages/.vitepress/theme/index.ts

@@ -14,11 +14,9 @@ import 'windi.css'
 const theme = {
   Layout,
   NotFound,
-  enhanceApp({ app, router }) {
+  enhanceApp({ router }) {
     if (typeof window !== 'undefined')
       handleRedirects(router)
-    // @ts-ignore: TODO: bring it back
-    // import('vite-plugin-editor-nav/client').then(i => i.default(router))
   },
 }
 

packages/core/useDraggable/index.ts

@@ -1,4 +1,4 @@
-import { Ref, ref, unref, computed } from 'vue'
+import { Ref, ref, unref, computed } from 'vue-demi'
 import { MaybeRef, toRefs } from '@vueuse/shared'
 import { useEventListener } from '../useEventListener'
 import { MaybeElementRef } from '../unrefElement'

packages/core/useEventBus/index.ts

@@ -5,7 +5,9 @@ import { events } from './internal'
 export type EventBusListener<T = unknown> = (event: T) => void
 export type EventBusEvents<T> = EventBusListener<T>[]
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 export interface EventBusKey<T> extends Symbol { }
+
 export type EventBusIdentifier<T = unknown> = EventBusKey<T> | string | number
 
 export interface UseEventBusReturn<T> {

packages/core/useVModel/index.test.ts

@@ -9,7 +9,7 @@ describe('useVModel', () => {
     [defaultKey]: defaultValue,
   })
 
-  const emitMock = jest.fn((event: string, values: any[]) => {})
+  const emitMock = jest.fn(() => {})
   beforeEach(() => emitMock.mockClear())
 
   it('should work with default value', () => {

packages/core/useWakeLock/index.test.ts

@@ -36,7 +36,7 @@ describe('useWakeLock', () => {
     }
 
     Object.defineProperty(navigator, 'wakeLock', {
-      value: { request: (_: 'screen') => createWakeLock() },
+      value: { request: () => createWakeLock() },
       writable: true,
     })
     const { isActive, request, release } = useWakeLock()
@@ -67,7 +67,7 @@ describe('useWakeLock', () => {
     }
 
     Object.defineProperty(navigator, 'wakeLock', {
-      value: { request: (_: 'screen') => createWakeLock() },
+      value: { request: () => createWakeLock() },
       writable: true,
     })
     const { isActive, request } = useWakeLock({ document: defaultDocument })

packages/core/useWebSocket/index.md

@@ -18,7 +18,7 @@ See the [Type Declarations](#type-declarations) for more options.
 
 ### Immediate
 
-Auto connect (enabled by default).
+Auto-connect (enabled by default).
 
 This will call `open()` automatically for you and you don't need to call it by yourself.
 

packages/firebase/useRTDB/index.md

@@ -43,10 +43,5 @@ export const useTodos = createGlobalState(
 // app.js
 import { useTodos } from './store'
 
-new Vue({
-  setup() {
-    const todos = useTodos()
-    return { todos }
-  },
-})
+const todos = useTodos()
 ```

packages/integrations/useFocusTrap/index.ts

@@ -1,6 +1,7 @@
 import { MaybeElementRef, unrefElement, tryOnScopeDispose, Fn } from '@vueuse/core'
 import { watch, ref, Ref } from 'vue-demi'
-import { ActivateOptions, createFocusTrap, DeactivateOptions, FocusTrap, Options } from 'focus-trap'
+import { createFocusTrap } from 'focus-trap'
+import type { ActivateOptions, DeactivateOptions, FocusTrap, Options } from 'focus-trap'
 
 export interface UseFocusTrapOptions extends Options {
   /**

packages/integrations/useJwt/index.test.ts

@@ -1,4 +1,4 @@
-import { JwtHeader, JwtPayload } from 'jwt-decode'
+import type { JwtHeader, JwtPayload } from 'jwt-decode'
 import { ref } from 'vue-demi'
 import { useSetup } from '../../.test'
 import { useJwt } from '.'

packages/integrations/useJwt/index.ts

@@ -1,6 +1,7 @@
 import { computed, ComputedRef, ref } from 'vue-demi'
 import { MaybeRef } from '@vueuse/shared'
-import jwt_decode, { JwtDecodeOptions, JwtHeader, JwtPayload } from 'jwt-decode'
+import jwt_decode from 'jwt-decode'
+import type { JwtDecodeOptions, JwtHeader, JwtPayload } from 'jwt-decode'
 
 export interface JwtOptions<Fallback> {
   /**

packages/rxjs/from/index.ts

@@ -1,4 +1,5 @@
-import { from as fromRxjs, fromEvent as fromEventRx, ObservableInput, Observable } from 'rxjs'
+import { from as fromRxjs, fromEvent as fromEventRx, Observable } from 'rxjs'
+import type { ObservableInput } from 'rxjs'
 import { filter, mergeMap } from 'rxjs/operators'
 import { Ref, isRef, watch } from 'vue-demi'
 

packages/rxjs/toObserver/index.ts

@@ -1,5 +1,5 @@
-import { NextObserver } from 'rxjs'
-import { Ref } from 'vue-demi'
+import type { NextObserver } from 'rxjs'
+import type { Ref } from 'vue-demi'
 
 export function toObserver<T>(value: Ref<T>): NextObserver<T> {
   return {

packages/shared/set/index.ts

@@ -14,6 +14,7 @@ export function set(...args: any[]) {
   if (args.length === 3) {
     if (isVue2) {
       // use @vue/composition-api's set API
+      // eslint-disable-next-line @typescript-eslint/no-var-requires
       require('vue-demi').set(...args)
     }
     else {

packages/shared/toReactive/index.ts

@@ -1,4 +1,4 @@
-import { isRef, toRefs as _toRefs, reactive } from 'vue-demi'
+import { isRef, reactive } from 'vue-demi'
 import { MaybeRef } from '../utils'
 
 /**

scripts/rollup.config.ts

@@ -3,7 +3,7 @@ import { resolve } from 'path'
 import typescript from 'rollup-plugin-typescript2'
 import { terser } from 'rollup-plugin-terser'
 import dts from 'rollup-plugin-dts'
-import { OutputOptions, Plugin, RollupOptions } from 'rollup'
+import type { OutputOptions, Plugin, RollupOptions } from 'rollup'
 import fg from 'fast-glob'
 import { activePackages } from '../meta/packages'