Skip to content

Commit

Permalink
fix(useMediaControls): better representation for "waiting" value
Browse files Browse the repository at this point in the history
waiting only fires when there's a lack of data in the middle of the playback. However, it doesn't take into account the lack of data when the source is attached to the element, as loadeddata does

"playing" also represents when a current playback is happening now
  • Loading branch information
ferferga committed May 7, 2023
1 parent 5a013bf commit b092cfe
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion packages/core/useMediaControls/index.ts
Expand Up @@ -388,10 +388,15 @@ export function useMediaControls(target: MaybeRef<HTMLMediaElement | null | unde
useEventListener(target, 'progress', () => buffered.value = timeRangeToArray((toValue(target))!.buffered))
useEventListener(target, 'seeking', () => seeking.value = true)
useEventListener(target, 'seeked', () => seeking.value = false)
useEventListener(target, 'waiting', () => waiting.value = true)
useEventListener(target, ['waiting', 'loadstart'], () => {
waiting.value = true
playing.value = false
})
useEventListener(target, 'loadeddata', () => waiting.value = false)
useEventListener(target, 'playing', () => {
waiting.value = false
ended.value = false
playing.value = true
})
useEventListener(target, 'ratechange', () => rate.value = (toValue(target))!.playbackRate)
useEventListener(target, 'stalled', () => stalled.value = true)
Expand Down

0 comments on commit b092cfe

Please sign in to comment.