fix(useElementSize): use contentBoxSize as an array in useElementSize #2520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threedayAAAAA
changed the title
threedayAAAAA
changed the title
vaakian
reviewed
Dec 18, 2022
| width.value = boxSize.reduce((acc, { inlineSize }) => acc + inlineSize, 0) | ||
| height.value = boxSize.reduce((acc, { blockSize }) => acc + blockSize, 0) | ||
| const formatBoxSize = Array.isArray(boxSize) ? boxSize : [boxSize] | ||
| if (formatBoxSize) { |
There was a problem hiding this comment.
boxSize may be undefined, so formatBoxSize may goes [ undefined ] and go into the if block.
Put the check inside the if block would be better.
There was a problem hiding this comment.
Is a good suggestion
There was a problem hiding this comment.
I have fixed it, please review again @vaakian
threedayAAAAA
force-pushed
the
fix-useElementSize-td
branch
from
e01600b
to
adb10a3
Compare
vaakian
previously approved these changes
Dec 20, 2022
|
Please merge this pr @antfu |
dpschen
previously approved these changes
Dec 30, 2022
threedayAAAAA
force-pushed
the
fix-useElementSize-td
branch
from
adb10a3
to
85be398
Compare
threedayAAAAA
force-pushed
the
fix-useElementSize-td
branch
from
efb09be
to
ab2d7fa
Compare
threedayAAAAA
force-pushed
the
fix-useElementSize-td
branch
from
ab2d7fa
to
0b12871
Compare
|
Hi, when can we expect a bugfix release? |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2519
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).