Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(useStorageAsync,useFetch): replace setTimeout with Promise #2917

Merged
merged 3 commits into from Apr 12, 2023
Merged

perf(useStorageAsync,useFetch): replace setTimeout with Promise #2917

merged 3 commits into from Apr 12, 2023

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Mar 29, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Put the event listener in useStorageAsync and the execute function in useFetch into a microtask queue to improve performance.

Additional context


🤖 Generated by Copilot at 7384070

Optimize useStorageAsync function by using Promise.resolve().then() instead of setTimeout() to defer reading from storage. Fix storage event issues.

🤖 Generated by Copilot at 7384070

  • Optimize the useStorageAsync function by using Promise.resolve().then() instead of setTimeout() to defer the read function (link)

@Alfred-Skyblue Alfred-Skyblue changed the title perf(useStorageAsync): setTimeout replaced with Promise perf(useStorageAsync): replace setTimeout with Promise Mar 29, 2023
@Alfred-Skyblue Alfred-Skyblue changed the title perf(useStorageAsync): replace setTimeout with Promise perf(useStorageAsync,useFetch): replace setTimeout with Promise Mar 29, 2023
@antfu antfu merged commit 8bd638b into vueuse:main Apr 12, 2023
4 checks passed
@Alfred-Skyblue Alfred-Skyblue deleted the perf-useStorageAsync branch May 9, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants