Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useIntersectionObserver): targets length check #2968

Merged
merged 1 commit into from Apr 14, 2023
Merged

Conversation

schelmo
Copy link
Contributor

@schelmo schelmo commented Apr 14, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

makes useIntersectionObserver actually work (and also useElementVisibility)

Additional context


🤖 Generated by Copilot at fa20a33

Fixed a bug in useIntersectionObserver that caused errors when no targets were provided. Improved the performance and reliability of the function.

🤖 Generated by Copilot at fa20a33

  • Fix early return condition in useIntersectionObserver to avoid unnecessary or invalid calls to observer.observe (link)

@antfu antfu merged commit b95b621 into vueuse:main Apr 14, 2023
1 check passed
@bpolaszek bpolaszek mentioned this pull request May 2, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants