Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useColorMode): disableTransition support pseudo-elements #3129

Merged
merged 3 commits into from Jun 6, 2023
Merged

feat(useColorMode): disableTransition support pseudo-elements #3129

merged 3 commits into from Jun 6, 2023

Conversation

lainbo
Copy link
Contributor

@lainbo lainbo commented May 31, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

pseudo-elements can also be used to apply various styles and effects. When switching between light and dark themes, the disableTransition parameter should control the disabling of transitions on pseudo-elements as well

Additional context


🤖 Generated by Copilot at af367dc

Fixed flashing elements bug during color mode change by updating the style string for disabling transitions in useColorMode to cover pseudo-elements. Improved style string readability with template literals and multiline strings.

🤖 Generated by Copilot at af367dc

  • Update the style string for disabling transitions to include pseudo-elements (link)
  • Format the style string using template literals and multiline strings for readability (link)

-ms-transition: none !important;
transition: none !important;
}
`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep it minified, as this is a string literal and the minifier won't do it.

@lainbo lainbo requested a review from antfu June 3, 2023 14:43
@antfu antfu merged commit 78a3a62 into vueuse:main Jun 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants