Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useTimeoutPoll): unexpected immediate execution #3159

Merged
merged 1 commit into from Jun 28, 2023

Conversation

jiadesen
Copy link
Contributor

@jiadesen jiadesen commented Jun 16, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

#2355

Additional context


🤖 Generated by Copilot at 7fa971f

Fixed a bug in useTimeoutPoll that caused the polling function to run immediately. Added an option to useTimeoutFn to delay the first execution.

🤖 Generated by Copilot at 7fa971f

  • Prevent polling function from running immediately on the first call by passing { immediate: false } option to useTimeoutFn (link). This fixes a bug reported in issue chore: use tryOnScopeDispose instead of tryOnUnmounted #674 and allows the user to control when to start the polling by calling the start function returned by useTimeoutPoll.

@antfu antfu changed the title fix(useTimeoutPoll): Unexpected immediate execution fix(useTimeoutPoll): unexpected immediate execution Jun 28, 2023
@antfu antfu merged commit 7a897e5 into vueuse:main Jun 28, 2023
1 check passed
@jiadesen jiadesen deleted the fix_timeoutPull_0616 branch June 28, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants