Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(useActiveElement): search deeply in shadow dom #3208

Merged
merged 4 commits into from Jul 30, 2023

Conversation

duoduoObama
Copy link
Contributor

@duoduoObama duoduoObama commented Jul 4, 2023

Compatible with shadow dom

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Additional context


🤖 Generated by Copilot at 6edb184

Support shadow DOM elements in useActiveElement hook. Add a helper function to get the deepest active element across shadow roots.

🤖 Generated by Copilot at 6edb184

  • Add support for shadow DOM elements in useActiveElement hook (link)

@antfu antfu changed the title Update index.ts feat(useActiveElement): search deeply in shadow dom Jul 30, 2023
@antfu antfu enabled auto-merge July 30, 2023 13:40
@antfu antfu added this pull request to the merge queue Jul 30, 2023
Merged via the queue into vueuse:main with commit 296dcc5 Jul 30, 2023
4 checks passed
@darrylnoakes
Copy link
Contributor

Isn't defaulting deep to true a breaking change? If this was already used to select a specific element that happens to use a shadow DOM, it will now select a different element.

@antfu
Copy link
Member

antfu commented Jul 31, 2023

Breaking change is relative, depends on how you rely on it a bugfix can be a breaking change as well. In this case, finding the "real active element" instead of "active element or shadow dom" make more sense to its definition to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants