Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useObjectUrl): improve parameter type #3239

Merged
merged 1 commit into from Jul 30, 2023
Merged

fix(useObjectUrl): improve parameter type #3239

merged 1 commit into from Jul 30, 2023

Conversation

ferreira-tb
Copy link
Contributor

@ferreira-tb ferreira-tb commented Jul 18, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Description

Allow object parameter type to have null as value. Also, changes MaybeRef type to MaybeRefOrGetter.


馃 Generated by Copilot at 6831346

Improved the useObjectUrl hook to support dynamic blob or media source creation. Added a function argument to the hook that can return a blob, a media source, or null.

馃 Generated by Copilot at 6831346

  • Replace MaybeRef with MaybeRefOrGetter to support dynamic blob or media source creation (link, link)
  • Allow passing null as a possible value for the source object (link)

@antfu antfu enabled auto-merge July 30, 2023 13:09
@antfu antfu added this pull request to the merge queue Jul 30, 2023
Merged via the queue into vueuse:main with commit d3f7e6a Jul 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants