Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onClickOutside): fix outside click on html element in ios #3252

Merged
merged 2 commits into from Jul 30, 2023

Conversation

sibbng
Copy link
Member

@sibbng sibbng commented Jul 23, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

In iOS if body has pointer-events: none, click events will happen on the html element but will not bubble up to the Window element. This fixes it.

Additional context

radix-vue/radix-vue#217


🤖 Generated by Copilot at b86ce87

Fix onClickOutside bug on Safari by adding a dummy event listener. This prevents Safari from firing a click event on the first touch after a touchend event.

🤖 Generated by Copilot at b86ce87

  • Work around Safari bug that triggers click event on first touch after touchend (link)

@antfu antfu added this pull request to the merge queue Jul 30, 2023
Merged via the queue into main with commit 9091e2c Jul 30, 2023
3 checks passed
@antfu antfu deleted the fix/onclickoutside-safari-html branch July 30, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants