Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useScroll): evade edge case when window or document is Proxy #3280

Merged
merged 2 commits into from Aug 25, 2023

Conversation

MinatoHikari
Copy link
Contributor

@MinatoHikari MinatoHikari commented Aug 1, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

fix #3136

the e.target/target will never be equal to window.document/window when it is a Proxy.

Additional context


🤖 Generated by Copilot at ab6806a

Refactor useScroll to use optional chaining and remove redundant checks. Improve readability and performance of getting scroll element and event target.

🤖 Generated by Copilot at ab6806a

  • Simplify the logic for getting the scroll element and the event target by using the optional chaining operator (??) (link, link)

@antfu antfu enabled auto-merge August 25, 2023 11:52
@antfu antfu added this pull request to the merge queue Aug 25, 2023
Merged via the queue into vueuse:main with commit c1b296c Aug 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useScroll: cannot pass window to "getComputedStyle" as an element
3 participants