feat(useWebNotification): add requestPermissions option, return permissionGranted and ensurePermissions
#3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on request onMounted refactor: amended useWebNotification() to optionally specify permission request onMounted
michealroberts
force-pushed
the
refactor/useWebNotification
branch
from
093dd7a
to
b77de15
Compare
michealroberts
changed the title
|
Updated the interface to align with https://vueuse.org/core/useDevicesList/#usedeviceslist, Also set the value default to true to avoid breaking |
antfu
changed the title
requestPermissions option, return permissionGranted and ensurePermissions
antfu
approved these changes
Aug 25, 2023
|
@michealroberts I'm a little late to the party but I think there's a typo here |
| if (!isSupported.value) | ||
| // If either the browser does not support notifications or the user has | ||
| // not granted permission, do nothing: | ||
| if (!isSupported.value && !permissionGranted.value) |
There was a problem hiding this comment.
shouldn't this be ||
if (!isSupported.value || !permissionGranted.value)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This MR addresses the usage concerns in #3314
This MR does not introduce breaking changes to the usage of the functional API, but introduces a change in the triggering of the notification request permission, i.e., it will no longer request permission
onMounted.🤖 Generated by Copilot at 093dd7a
This pull request enhances the
useWebNotificationhook with a new option and helper functions to request permission for web notifications more flexibly and conveniently. It also updates the documentation with an example of using the new option.🤖 Generated by Copilot at 093dd7a
requestOnMountedoption touseWebNotificationhook to control when permission is requested (link,link,link,link)hasPermissionandrequestPermissionfunctions (link,link,link)defaultOptionstodefaultWebNotificationOptionsand destructurewindowoption (link,link)useWebNotification/index.mdwith new option and functions (link)